darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gdb/

Browse source 
* memrange.c (compare_mem_ranges): Mention sort order in
	describing comment.
	(normalize_mem_ranges): Add comment.  Fix ra->length calculation.
	* tracepoint.c (traceframe_available_memory): Extend comment to
	mention what happens to RESULT when the target does not support
	the query.
This commit is contained in:
Pedro Alves 2011-02-14 19:19:18 +00:00
parent 602427c4af
commit c0f61f9c37
3 changed files with 22 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gdb/ChangeLog
View file

@ -1,3 +1,12 @@
2011-02-14 Pedro Alves <pedro@codesourcery.com>
* memrange.c (compare_mem_ranges): Mention sort order in
describing comment.
(normalize_mem_ranges): Add comment. Fix ra->length calculation.
* tracepoint.c (traceframe_available_memory): Extend comment to
mention what happens to RESULT when the target does not support
the query.
2011-02-14 Pedro Alves <pedro@codesourcery.com>
Jan Kratochvil <jan.kratochvil@redhat.com>

10
gdb/memrange.c
View file

@ -31,7 +31,8 @@ mem_ranges_overlap (CORE_ADDR start1, int len1,
return (l < h);
}
/* qsort comparison function, that compares mem_ranges. */
/* qsort comparison function, that compares mem_ranges. Ranges are
sorted in ascending START order. */
static int
compare_mem_ranges (const void *ap, const void *bp)
@ -50,6 +51,10 @@ compare_mem_ranges (const void *ap, const void *bp)
void
normalize_mem_ranges (VEC(mem_range_s) *ranges)
{
/* This function must not use any VEC operation on RANGES that
reallocates the memory block as that invalidates the RANGES
pointer, which callers expect to remain valid. */
if (!VEC_empty (mem_range_s, ranges))
{
struct mem_range *ra, *rb;
@ -68,7 +73,8 @@ normalize_mem_ranges (VEC(mem_range_s) *ranges)
merge them. */
if (rb->start <= ra->start + ra->length)
{
ra->length = (rb->start + rb->length) - ra->start;
ra->length = max (ra->length,
(rb->start - ra->start) + rb->length);
continue; /* next b, same a */
}
a++; /* next a */

9
gdb/tracepoint.c
View file

@ -4635,10 +4635,11 @@ get_traceframe_info (void)
return traceframe_info;
}
/* Return in RESULT, the set of collected memory in the current
traceframe, found within the LEN bytes range starting at MEMADDR.
Returns true if the target supports the query, otherwise returns
false. */
/* If the target supports the query, return in RESULT the set of
collected memory in the current traceframe, found within the LEN
bytes range starting at MEMADDR. Returns true if the target
supports the query, otherwise returns false, and RESULT is left
undefined. */
int
traceframe_available_memory (VEC(mem_range_s) **result,