darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* findvar.c (read_var_value): Don't allocate V when it will not

Browse source 
be used.  Add missing break for LOC_INDIRECT.
This commit is contained in:
Daniel Jacobowitz 2005-03-07 22:38:04 +00:00
parent 384e1a6106
commit bb04426270
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2005-03-07 Daniel Jacobowitz <dan@codesourcery.com>
* findvar.c (read_var_value): Don't allocate V when it will not
be used. Add missing break for LOC_INDIRECT.
2005-03-06 Mark Kettenis <kettenis@gnu.org>
* sparc64fbsd-tdep.c: Include "solib-svr4.h".

15
gdb/findvar.c
View file

@ -385,12 +385,20 @@ read_var_value (struct symbol *var, struct frame_info *frame)
CORE_ADDR addr;
int len;
v = allocate_value (type);
VALUE_LVAL (v) = lval_memory; /* The most likely possibility. */
if (SYMBOL_CLASS (var) == LOC_COMPUTED
|| SYMBOL_CLASS (var) == LOC_COMPUTED_ARG
|| SYMBOL_CLASS (var) == LOC_REGISTER
|| SYMBOL_CLASS (var) == LOC_REGPARM)
/* These cases do not use V. */
v = NULL;
else
{
v = allocate_value (type);
VALUE_LVAL (v) = lval_memory; /* The most likely possibility. */
}
len = TYPE_LENGTH (type);
/* FIXME drow/2003-09-06: this call to the selected frame should be
pushed upwards to the callers. */
if (frame == NULL)
@ -452,6 +460,7 @@ addresses have not been bound by the dynamic loader. Try again when executable i
locaddr = SYMBOL_VALUE_ADDRESS (var);
loc = value_at (lookup_pointer_type (type), locaddr);
addr = value_as_address (loc);
break;
}
case LOC_ARG: