darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

epiphany/disassembler: Improve alignment of output.

Browse source 
Always set the bytes_per_line field (of struct disassemble_info) to the
same constant value, this is inline with the advice contained within
include/dis-asm.h.

Setting this field to a constant value will cause the disassembler
output to be better aligned.

cpu/ChangeLog:

	* epiphany.opc (epiphany_print_insn): Set info->bytes_per_line to
	a constant to better align disassembler output.

opcodes/ChangeLog:

	* epiphany-dis.c: Regenerated from latest cpu files.

gas/ChangeLog:

	* testsuite/gas/epiphany/sample.d: Update expected output.
This commit is contained in:
Andrew Burgess 2016-02-01 18:21:37 +00:00
parent 3f2f6cb5e8
commit b89807c67b
6 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cpu/ChangeLog
View file

@ -1,3 +1,8 @@
2016-02-02 Andrew Burgess <andrew.burgess@embecosm.com>
* epiphany.opc (epiphany_print_insn): Set info->bytes_per_line to
a constant to better align disassembler output.
2014-07-20 Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> 2014-07-20 Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
* or1korbis.cpu (l-msync, l-psync, l-csync): New instructions. * or1korbis.cpu (l-msync, l-psync, l-csync): New instructions.

5
cpu/epiphany.opc
View file

@ -349,15 +349,16 @@ epiphany_print_insn (CGEN_CPU_DESC cd, bfd_vma pc, disassemble_info *info)
int status; int status;
info->bytes_per_chunk = 2; info->bytes_per_chunk = 2;
info->bytes_per_line = 4;
/* Attempt to read the base part of the insn. */ /* Attempt to read the base part of the insn. */
info->bytes_per_line = buflen = cd->base_insn_bitsize / 8; buflen = cd->base_insn_bitsize / 8;
status = (*info->read_memory_func) (pc, buf, buflen, info); status = (*info->read_memory_func) (pc, buf, buflen, info);
/* Try again with the minimum part, if min < base. */ /* Try again with the minimum part, if min < base. */
if (status != 0 && (cd->min_insn_bitsize < cd->base_insn_bitsize)) if (status != 0 && (cd->min_insn_bitsize < cd->base_insn_bitsize))
{ {
info->bytes_per_line = buflen = cd->min_insn_bitsize / 8; buflen = cd->min_insn_bitsize / 8;
status = (*info->read_memory_func) (pc, buf, buflen, info); status = (*info->read_memory_func) (pc, buf, buflen, info);
} }

4
gas/ChangeLog
View file

@ -1,3 +1,7 @@
2016-02-02 Andrew Burgess <andrew.burgess@embecosm.com>
* testsuite/gas/epiphany/sample.d: Update expected output.
2016-01-26 Claudiu Zissulescu <claziss@synopsys.com> 2016-01-26 Claudiu Zissulescu <claziss@synopsys.com>
* config/tc-arc.c (md_apply_fix): Allow addendum. * config/tc-arc.c (md_apply_fix): Allow addendum.

2
gas/testsuite/gas/epiphany/sample.d
View file

@ -218,4 +218,4 @@ Disassembly of section \.text:
0000019e \<trap\>: 0000019e \<trap\>:
19e: 03e2 trap 0x0 19e: 03e2 trap 0x0
1a0: 01d2 rti 1a0: 01d2 rti

4
opcodes/ChangeLog
View file

@ -1,3 +1,7 @@
2016-02-02 Andrew Burgess <andrew.burgess@embecosm.com>
* epiphany-dis.c: Regenerated from latest cpu files.
2016-02-01 Michael McConville <mmcco@mykolab.com> 2016-02-01 Michael McConville <mmcco@mykolab.com>
* cgen-dis.c (count_decodable_bits): Use unsigned value for mask * cgen-dis.c (count_decodable_bits): Use unsigned value for mask

5
opcodes/epiphany-dis.c
View file

@ -69,15 +69,16 @@ epiphany_print_insn (CGEN_CPU_DESC cd, bfd_vma pc, disassemble_info *info)
int status; int status;
info->bytes_per_chunk = 2; info->bytes_per_chunk = 2;
info->bytes_per_line = 4;
/* Attempt to read the base part of the insn. */ /* Attempt to read the base part of the insn. */
info->bytes_per_line = buflen = cd->base_insn_bitsize / 8; buflen = cd->base_insn_bitsize / 8;
status = (*info->read_memory_func) (pc, buf, buflen, info); status = (*info->read_memory_func) (pc, buf, buflen, info);
/* Try again with the minimum part, if min < base. */ /* Try again with the minimum part, if min < base. */
if (status != 0 && (cd->min_insn_bitsize < cd->base_insn_bitsize)) if (status != 0 && (cd->min_insn_bitsize < cd->base_insn_bitsize))
{ {
info->bytes_per_line = buflen = cd->min_insn_bitsize / 8; buflen = cd->min_insn_bitsize / 8;
status = (*info->read_memory_func) (pc, buf, buflen, info); status = (*info->read_memory_func) (pc, buf, buflen, info);
} }