darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't build readline's shared libs by default

Browse source 
Since the sync to version 7.0-alpho, readline now by default builds
(unused) shared libraries alongside static libraries, whereas before it
only built static libraries.  A couple of GDB buildbots were not happy
with this change:

  http://gdb-build.sergiodj.net/builders/AIX-POWER7-plain/builds/240
  http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1518

To get these buildbots building again, this patch alters readline's
configure.ac file to not build shared libraries by default, as was the
case with readline 6.2.  A more permanent fix may be to alter the
top-level Makefile.def to pass --disable-shared to readline, or to
investigate why these building these shared libraries are giving the
buildbots trouble.  (I think the proximate reason why the i686 buildbot
fails is because it passes CFLAGS=-m32 instead of CC="gcc -m32" to the
top-level configure script, and readline's linker commands don't inherit
CFLAGS.  Not sure about the AIX failure.)

readline/ChangeLog.gdb:

	* configure.ac: Default opt_shared_libs to no.
	* configure: Regenerate.
This commit is contained in:
Patrick Palka 2015-07-25 11:14:34 -04:00
parent 18d9555c6e
commit b558ff043d
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
readline/ChangeLog.gdb
View file

@ -1,3 +1,8 @@
2015-07-25 Patrick Palka <patrick@parcs.ath.cx>
* configure.ac: Default opt_shared_libs to no.
* configure: Regenerate.
2015-07-25 Patrick Palka <patrick@parcs.ath.cx>
Import readline 7.0 alpha

2
readline/configure vendored
View file

@ -2352,7 +2352,7 @@ fi
opt_multibyte=yes
opt_static_libs=yes
opt_shared_libs=yes
opt_shared_libs=no
# Check whether --enable-multibyte was given.
if test "${enable_multibyte+set}" = set; then :

2
readline/configure.ac
View file

@ -58,7 +58,7 @@ fi
dnl option parsing for optional features
opt_multibyte=yes
opt_static_libs=yes
opt_shared_libs=yes
opt_shared_libs=no
AC_ARG_ENABLE(multibyte, AC_HELP_STRING([--enable-multibyte], [enable multibyte characters if OS supports them]), opt_multibyte=$enableval)
AC_ARG_ENABLE(shared, AC_HELP_STRING([--enable-shared], [build shared libraries [[default=YES]]]), opt_shared_libs=$enableval)