darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

linux-record: Fix bad fall-through for pipe/pipe2

Browse source 
This patch added handling for some syscalls to linux-record.c:

  https://sourceware.org/ml/gdb-patches/2015-10/msg00452.html

But for both `pipe' and `pipe2' the patch lacks a statement after an
`if', such that the following `break' is interpreted as the `if'-body
instead.

This adds the missing (return-) statements for the conditionals.

gdb/ChangeLog:

	* linux-record.c (record_linux_system_call): Add missing return
	statements to handling of pipe and pipe2 syscalls.
This commit is contained in:
Andreas Arnez 2016-03-17 09:58:56 +01:00
parent f3f8e58e93
commit afdab91654
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2016-03-17 Andreas Arnez <arnez@linux.vnet.ibm.com>
* linux-record.c (record_linux_system_call): Add missing return
statements to handling of pipe and pipe2 syscalls.
2016-03-16 Doug Evans <dje@google.com>
* xml-tdesc.c (tdesc_start_enum): Fix c++ build.

2
gdb/linux-record.c
View file

@ -354,6 +354,7 @@ record_linux_system_call (enum gdb_syscall syscall,
regcache_raw_read_unsigned (regcache, tdep->arg1, &tmpulongest);
if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
tdep->size_int * 2))
return -1;
break;
case gdb_sys_times:
@ -2312,6 +2313,7 @@ Do you want to stop the program?"),
regcache_raw_read_unsigned (regcache, tdep->arg1, &tmpulongest);
if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
tdep->size_int * 2))
return -1;
break;
case gdb_sys_inotify_init1: