darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cleanup FLT_CHARS and EXP_CHARS

Browse source 
Providing declarations in tc.h points out that alpha wasn't properly marking
FLT_CHARS as const.  We can also get rid of the confusing redefinition of
X_CHARS to mmix_x_chars.  Finally we can get rid of some now redundant
declarations of these constants.

gas/ChangeLog:

2016-04-03  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-alpha.c: Const qualify FLT_CHARS.
	* config/atof-ieee.c: Remove declarations of FLT_CHARS and EXP_CHARS.
	* config/tc-cris.h: Likewise.
	* expr.c: Likewise.
	* config/tc-mmix.c (md_atof): Adjust comment.
	* config/tc-mmix.h: Stop defining FLT_CHARS and EXP_CHARS as macros.
	* tc.h: Declare FLT_CHARS and EXP_CHARS.
This commit is contained in:
Trevor Saunders 2016-04-02 16:38:40 -04:00
parent a51ef39291
commit ae2689b09f
8 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gas/ChangeLog
View file

@ -1,3 +1,13 @@
2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-alpha.c: Const qualify FLT_CHARS.
* config/atof-ieee.c: Remove declarations of FLT_CHARS and EXP_CHARS.
* config/tc-cris.h: Likewise.
* expr.c: Likewise.
* config/tc-mmix.c (md_atof): Adjust comment.
* config/tc-mmix.h: Stop defining FLT_CHARS and EXP_CHARS as macros.
* tc.h: Declare FLT_CHARS and EXP_CHARS.
2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org> 2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-score.c (s3_gen_reloc): Add const qualifiers. * config/tc-score.c (s3_gen_reloc): Add const qualifiers.

2
gas/config/atof-ieee.c
View file

@ -23,7 +23,6 @@
/* Flonums returned here. */ /* Flonums returned here. */
extern FLONUM_TYPE generic_floating_point_number; extern FLONUM_TYPE generic_floating_point_number;
extern const char EXP_CHARS[];
/* Precision in LittleNums. */ /* Precision in LittleNums. */
/* Don't count the gap in the m68k extended precision format. */ /* Don't count the gap in the m68k extended precision format. */
#define MAX_PRECISION 5 #define MAX_PRECISION 5
@ -696,7 +695,6 @@ print_gen (gen)
} }
#endif #endif
extern const char FLT_CHARS[];
#define MAX_LITTLENUMS 6 #define MAX_LITTLENUMS 6
/* This is a utility function called from various tc-*.c files. It /* This is a utility function called from various tc-*.c files. It

2
gas/config/tc-alpha.c
View file

@ -241,7 +241,7 @@ const char EXP_CHARS[] = "eE";
/* Characters which mean that a number is a floating point constant, /* Characters which mean that a number is a floating point constant,
as in 0d1.0. */ as in 0d1.0. */
/* XXX: Do all of these really get used on the alpha?? */ /* XXX: Do all of these really get used on the alpha?? */
char FLT_CHARS[] = "rRsSfFdDxXpP"; const char FLT_CHARS[] = "rRsSfFdDxXpP";
#ifdef OBJ_EVAX #ifdef OBJ_EVAX
const char *md_shortopts = "Fm:g+1h:HG:"; const char *md_shortopts = "Fm:g+1h:HG:";

2
gas/config/tc-cris.h
View file

@ -54,8 +54,6 @@ extern const pseudo_typeS md_pseudo_table[];
extern const char cris_comment_chars[]; extern const char cris_comment_chars[];
extern const char line_comment_chars[]; extern const char line_comment_chars[];
extern const char line_separator_chars[]; extern const char line_separator_chars[];
extern const char EXP_CHARS[];
extern const char FLT_CHARS[];
/* This should be optional, since it is ignored as an escape (assumed to /* This should be optional, since it is ignored as an escape (assumed to
be itself) if it is not recognized. */ be itself) if it is not recognized. */

6
gas/config/tc-mmix.c
View file

@ -395,9 +395,9 @@ const char line_comment_chars[] = "*#";
const char line_separator_chars[] = ";"; const char line_separator_chars[] = ";";
const char mmix_exp_chars[] = "eE"; const char EXP_CHARS[] = "eE";
const char mmix_flt_chars[] = "rf"; const char FLT_CHARS[] = "rf";
/* Fill in the offset-related part of GETA or Bcc. */ /* Fill in the offset-related part of GETA or Bcc. */
@ -2277,7 +2277,7 @@ md_atof (int type, char *litP, int *sizeP)
{ {
if (type == 'r') if (type == 'r')
type = 'f'; type = 'f';
/* FIXME: Having 'f' in mmix_flt_chars (and here) makes it /* FIXME: Having 'f' in FLT_CHARS (and here) makes it
problematic to also have a forward reference in an expression. problematic to also have a forward reference in an expression.
The testsuite wants it, and it's customary. The testsuite wants it, and it's customary.
We'll deal with the real problems when they come; we share the We'll deal with the real problems when they come; we share the

6
gas/config/tc-mmix.h
View file

@ -32,12 +32,6 @@ extern const char mmix_comment_chars[];
extern const char mmix_symbol_chars[]; extern const char mmix_symbol_chars[];
#define tc_symbol_chars mmix_symbol_chars #define tc_symbol_chars mmix_symbol_chars
extern const char mmix_exp_chars[];
#define EXP_CHARS mmix_exp_chars
extern const char mmix_flt_chars[];
#define FLT_CHARS mmix_flt_chars
/* "@" is a synonym for ".". */ /* "@" is a synonym for ".". */
#define LEX_AT (LEX_BEGIN_NAME) #define LEX_AT (LEX_BEGIN_NAME)

2
gas/expr.c
View file

@ -46,8 +46,6 @@ static void clean_up_expression (expressionS * expressionP);
static segT operand (expressionS *, enum expr_mode); static segT operand (expressionS *, enum expr_mode);
static operatorT operatorf (int *); static operatorT operatorf (int *);
extern const char EXP_CHARS[], FLT_CHARS[];
/* We keep a mapping of expression symbols to file positions, so that /* We keep a mapping of expression symbols to file positions, so that
we can provide better error messages. */ we can provide better error messages. */

3
gas/tc.h
View file

@ -75,3 +75,6 @@ extern arelent *tc_gen_reloc (asection *, fixS *);
#else #else
extern arelent **tc_gen_reloc (asection *, fixS *); extern arelent **tc_gen_reloc (asection *, fixS *);
#endif #endif
extern const char FLT_CHARS[];
extern const char EXP_CHARS[];