darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Eliminate clear_quit_flag

Browse source 
Nothing calls this anymore.

gdb/ChangeLog:
2016-04-12  Pedro Alves  <palves@redhat.com>

	* defs.h (clear_quit_flag): Remove declaration.
	* extension-priv.h (struct extension_language_ops)
	<clear_quit_flag>: Remove field and update comments.
	* extension.c (clear_quit_flag): Delete.
	* guile/guile.c (guile_extension_ops): Adjust.
	* python/python.c (python_extension_ops): Adjust.
	(gdbpy_clear_quit_flag): Delete.
This commit is contained in:
Pedro Alves 2016-04-12 16:49:31 +01:00
parent da1e5f545c
commit a149683b0c
6 changed files with 11 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gdb/ChangeLog
View file

@ -1,3 +1,13 @@
2016-04-12 Pedro Alves <palves@redhat.com>
* defs.h (clear_quit_flag): Remove declaration.
* extension-priv.h (struct extension_language_ops)
<clear_quit_flag>: Remove field and update comments.
* extension.c (clear_quit_flag): Delete.
* guile/guile.c (guile_extension_ops): Adjust.
* python/python.c (python_extension_ops): Adjust.
(gdbpy_clear_quit_flag): Delete.
2016-04-12 Pedro Alves <palves@redhat.com> 2016-04-12 Pedro Alves <palves@redhat.com>
* main.c (captured_main): Don't clear the quit flag. * main.c (captured_main): Don't clear the quit flag.

2
gdb/defs.h
View file

@ -139,8 +139,6 @@ extern char *debug_file_directory;
These functions use the extension_language_ops API to allow extension These functions use the extension_language_ops API to allow extension
language(s) and GDB SIGINT handling to coexist seamlessly. */ language(s) and GDB SIGINT handling to coexist seamlessly. */
/* * Clear the quit flag. */
extern void clear_quit_flag (void);
/* * Evaluate to non-zero if the quit flag is set, zero otherwise. This /* * Evaluate to non-zero if the quit flag is set, zero otherwise. This
will clear the quit flag as a side effect. */ will clear the quit flag as a side effect. */
extern int check_quit_flag (void); extern int check_quit_flag (void);

5
gdb/extension-priv.h
View file

@ -232,7 +232,7 @@ struct extension_language_ops
enum ext_lang_bp_stop (*breakpoint_cond_says_stop) enum ext_lang_bp_stop (*breakpoint_cond_says_stop)
(const struct extension_language_defn *, struct breakpoint *); (const struct extension_language_defn *, struct breakpoint *);
/* The next three are used to connect GDB's SIGINT handling with the /* The next two are used to connect GDB's SIGINT handling with the
extension language's. extension language's.
Terminology: If an extension language can use GDB's SIGINT handling then Terminology: If an extension language can use GDB's SIGINT handling then
@ -242,9 +242,6 @@ struct extension_language_ops
These need not be implemented, but if one of them is implemented These need not be implemented, but if one of them is implemented
then they all must be. */ then they all must be. */
/* Clear the SIGINT indicator. */
void (*clear_quit_flag) (const struct extension_language_defn *);
/* Set the SIGINT indicator. /* Set the SIGINT indicator.
This is called by GDB's SIGINT handler and must be async-safe. */ This is called by GDB's SIGINT handler and must be async-safe. */
void (*set_quit_flag) (const struct extension_language_defn *); void (*set_quit_flag) (const struct extension_language_defn *);

19
gdb/extension.c
View file

@ -794,25 +794,6 @@ restore_active_ext_lang (struct active_ext_lang_state *previous)
xfree (previous); xfree (previous);
} }
/* Clear the quit flag.
The flag is cleared in all extension languages,
not just the currently active one. */
void
clear_quit_flag (void)
{
int i;
const struct extension_language_defn *extlang;
ALL_ENABLED_EXTENSION_LANGUAGES (i, extlang)
{
if (extlang->ops->clear_quit_flag != NULL)
extlang->ops->clear_quit_flag (extlang);
}
quit_flag = 0;
}
/* Set the quit flag. /* Set the quit flag.
This only sets the flag in the currently active extension language. This only sets the flag in the currently active extension language.
If the currently active extension language does not have cooperative If the currently active extension language does not have cooperative

1
gdb/guile/guile.c
View file

@ -155,7 +155,6 @@ const struct extension_language_ops guile_extension_ops =
gdbscm_breakpoint_cond_says_stop, gdbscm_breakpoint_cond_says_stop,
NULL, /* gdbscm_check_quit_flag, */ NULL, /* gdbscm_check_quit_flag, */
NULL, /* gdbscm_clear_quit_flag, */
NULL, /* gdbscm_set_quit_flag, */ NULL, /* gdbscm_set_quit_flag, */
}; };

11
gdb/python/python.c
View file

@ -146,7 +146,6 @@ static enum ext_lang_rc gdbpy_apply_type_printers
const struct ext_lang_type_printers *, struct type *, char **); const struct ext_lang_type_printers *, struct type *, char **);
static void gdbpy_free_type_printers (const struct extension_language_defn *, static void gdbpy_free_type_printers (const struct extension_language_defn *,
struct ext_lang_type_printers *); struct ext_lang_type_printers *);
static void gdbpy_clear_quit_flag (const struct extension_language_defn *);
static void gdbpy_set_quit_flag (const struct extension_language_defn *); static void gdbpy_set_quit_flag (const struct extension_language_defn *);
static int gdbpy_check_quit_flag (const struct extension_language_defn *); static int gdbpy_check_quit_flag (const struct extension_language_defn *);
static enum ext_lang_rc gdbpy_before_prompt_hook static enum ext_lang_rc gdbpy_before_prompt_hook
@ -184,7 +183,6 @@ const struct extension_language_ops python_extension_ops =
gdbpy_breakpoint_has_cond, gdbpy_breakpoint_has_cond,
gdbpy_breakpoint_cond_says_stop, gdbpy_breakpoint_cond_says_stop,
gdbpy_clear_quit_flag,
gdbpy_set_quit_flag, gdbpy_set_quit_flag,
gdbpy_check_quit_flag, gdbpy_check_quit_flag,
@ -270,15 +268,6 @@ ensure_python_env (struct gdbarch *gdbarch,
return make_cleanup (restore_python_env, env); return make_cleanup (restore_python_env, env);
} }
/* Clear the quit flag. */
static void
gdbpy_clear_quit_flag (const struct extension_language_defn *extlang)
{
/* This clears the flag as a side effect. */
PyOS_InterruptOccurred ();
}
/* Set the quit flag. */ /* Set the quit flag. */
static void static void