darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

2011-03-04 Michael Snyder <msnyder@vmware.com>

Browse source 
* symfile.c (simple_overlay_update): Check for null return value
	from lookup_minimal_symbol.
This commit is contained in:
Michael Snyder 2011-03-05 00:52:41 +00:00
parent cfdee94ab4
commit 9cc8966527
2 changed files with 21 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gdb/ChangeLog
View file

@ -1,5 +1,8 @@
2011-03-04 Michael Snyder <msnyder@vmware.com>
* symfile.c (simple_overlay_update): Check for null return value
from lookup_minimal_symbol.
* gdbserver/server.c (queue_stop_reply): Call xmalloc not malloc.
* xml-syscall.c (syscall_start_syscall): Assert name is non null.

21
gdb/symfile.c
View file

@ -3432,15 +3432,24 @@ simple_overlay_update (struct obj_section *osect)
if (osect)
/* Have we got a cached copy of the target's overlay table? */
if (cache_ovly_table != NULL)
/* Does its cached location match what's currently in the symtab? */
if (cache_ovly_table_base ==
SYMBOL_VALUE_ADDRESS (lookup_minimal_symbol ("_ovly_table",
NULL, NULL)))
/* Then go ahead and try to look up this single section in the
cache. */
{
/* Does its cached location match what's currently in the
symtab? */
struct minimal_symbol *minsym
= lookup_minimal_symbol ("_ovly_table", NULL, NULL);
if (minsym == NULL)
error (_("Error reading inferior's overlay table: couldn't "
"find `_ovly_table' array\n"
"in inferior. Use `overlay manual' mode."));
if (cache_ovly_table_base == SYMBOL_VALUE_ADDRESS (minsym))
/* Then go ahead and try to look up this single section in
the cache. */
if (simple_overlay_update_1 (osect))
/* Found it! We're done. */
return;
}
/* Cached table no good: need to read the entire table anew.
Or else we want all the sections, in which case it's actually