darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* minsyms.c (lookup_minimal_symbol_by_pc_section): Search fewer

Browse source 
objfiles.
This commit is contained in:
Daniel Jacobowitz 2007-07-01 22:39:04 +00:00
parent 1b05479a47
commit 962257181f
2 changed files with 18 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2007-07-01 Daniel Jacobowitz <dan@codesourcery.com>
* minsyms.c (lookup_minimal_symbol_by_pc_section): Search fewer
objfiles.
2007-07-01 Daniel Jacobowitz <dan@codesourcery.com>
* top.c (gdb_readline_wrapper_line): Call rl_callback_handler_remove.

26
gdb/minsyms.c
View file

@ -387,20 +387,20 @@ lookup_minimal_symbol_by_pc_section (CORE_ADDR pc, asection *section)
if (pc_section == NULL)
return NULL;
/* NOTE: cagney/2004-01-27: Removed code (added 2003-07-19) that was
trying to force the PC into a valid section as returned by
find_pc_section. It broke IRIX 6.5 mdebug which relies on this
code returning an absolute symbol - the problem was that
find_pc_section wasn't returning an absolute section and hence
the code below would skip over absolute symbols. Since the
original problem was with finding a frame's function, and that
uses [indirectly] lookup_minimal_symbol_by_pc, the original
problem has been fixed by having that function use
find_pc_section. */
/* We can not require the symbol found to be in pc_section, because
e.g. IRIX 6.5 mdebug relies on this code returning an absolute
symbol - but find_pc_section won't return an absolute section and
hence the code below would skip over absolute symbols. We can
still take advantage of the call to find_pc_section, though - the
object file still must match. In case we have separate debug
files, search both the file and its separate debug file. There's
no telling which one will have the minimal symbols. */
for (objfile = object_files;
objfile != NULL;
objfile = objfile->next)
objfile = pc_section->objfile;
if (objfile->separate_debug_objfile)
objfile = objfile->separate_debug_objfile;
for (; objfile != NULL; objfile = objfile->separate_debug_objfile_backlink)
{
/* If this objfile has a minimal symbol table, go search it using
a binary search. Note that a minimal symbol table always consists