darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[AArch64] Call abort() consistently in unhandled stub switch statements.

Browse source 
Ensure we hard stop via abort() for unhandled stub types rather than
continuing either silently (or noisly with a BFD_FAIL()).

Call abort() giving a hard stop rather than BFD_FAIL () for unhandled
stub types.
This commit is contained in:
Marcus Shawcroft 2015-03-02 12:12:37 +00:00
parent 87de11c052
commit 8e2fe09f70
2 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bfd/ChangeLog
View file

@ -1,3 +1,9 @@
2015-03-04 Marcus Shawcroft <marcus.shawcroft@arm.com>
* elfnn-aarch64.c (aarch64_build_one_stub): Call abort.
(aarch64_size_one_stub): Likewise.
(aarch64_map_one_stub): Likewise.
2015-03-04 Andreas Arnez <arnez@linux.vnet.ibm.com> 2015-03-04 Andreas Arnez <arnez@linux.vnet.ibm.com>
* cpu-s390.c (N): New macro. * cpu-s390.c (N): New macro.

11
bfd/elfnn-aarch64.c
View file

@ -2445,8 +2445,7 @@ aarch64_build_one_stub (struct bfd_hash_entry *gen_entry,
template_size = sizeof (aarch64_erratum_835769_stub); template_size = sizeof (aarch64_erratum_835769_stub);
break; break;
default: default:
BFD_FAIL (); abort ();
return FALSE;
} }
for (i = 0; i < (template_size / sizeof template[0]); i++) for (i = 0; i < (template_size / sizeof template[0]); i++)
@ -2504,7 +2503,7 @@ aarch64_build_one_stub (struct bfd_hash_entry *gen_entry,
break; break;
default: default:
break; abort ();
} }
return TRUE; return TRUE;
@ -2535,9 +2534,7 @@ aarch64_size_one_stub (struct bfd_hash_entry *gen_entry,
size = sizeof (aarch64_erratum_835769_stub); size = sizeof (aarch64_erratum_835769_stub);
break; break;
default: default:
BFD_FAIL (); abort ();
return FALSE;
break;
} }
size = (size + 7) & ~7; size = (size + 7) & ~7;
@ -6552,7 +6549,7 @@ aarch64_map_one_stub (struct bfd_hash_entry *gen_entry, void *in_arg)
return FALSE; return FALSE;
break; break;
default: default:
BFD_FAIL (); abort ();
} }
return TRUE; return TRUE;