darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* dwarf2expr.c (get_signed_type): New function.

Browse source 
(execute_stack_op) <DW_OP_shra>: Always perform a signed shift.
This commit is contained in:
Tom Tromey 2011-06-03 14:57:29 +00:00
parent 331fe61622
commit 8ddd9a20a7
2 changed files with 39 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2011-06-03 Tom Tromey <tromey@redhat.com>
* dwarf2expr.c (get_signed_type): New function.
(execute_stack_op) <DW_OP_shra>: Always perform a signed shift.
2011-06-02 Keith Seitz <keiths@redhat.com>
* objc-lang.c (find_methods): Increment objfile_csym earlier.

34
gdb/dwarf2expr.c
View file

@ -229,6 +229,28 @@ get_unsigned_type (struct gdbarch *gdbarch, struct type *type)
}
}
/* Return the signed form of TYPE. TYPE is necessarily an integral
type. */
static struct type *
get_signed_type (struct gdbarch *gdbarch, struct type *type)
{
switch (TYPE_LENGTH (type))
{
case 1:
return builtin_type (gdbarch)->builtin_int8;
case 2:
return builtin_type (gdbarch)->builtin_int16;
case 4:
return builtin_type (gdbarch)->builtin_int32;
case 8:
return builtin_type (gdbarch)->builtin_int64;
default:
error (_("no signed variant found for type, while evaluating "
"DWARF expression"));
}
}
/* Retrieve the N'th item on CTX's stack, converted to an address. */
CORE_ADDR
@ -996,7 +1018,19 @@ execute_stack_op (struct dwarf_expr_context *ctx,
case DW_OP_shra:
dwarf_require_integral (value_type (first));
dwarf_require_integral (value_type (second));
if (TYPE_UNSIGNED (value_type (first)))
{
struct type *stype
= get_signed_type (ctx->gdbarch, value_type (first));
first = value_cast (stype, first);
}
result_val = value_binop (first, second, BINOP_RSH);
/* Make sure we wind up with the same type we started
with. */
if (value_type (result_val) != value_type (second))
result_val = value_cast (value_type (second), result_val);
break;
case DW_OP_xor:
dwarf_require_integral (value_type (first));