darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

PR gdb/10728

Browse source 
* valarith.c (value_ptrdiff): Added a test for a zero type length,
	warn if found, and assume length = 1.
* gdb.cp/pr10728-x.h: New file.
* gdb.cp/pr10728-x.cc: New file.
* gdb.cp/pr10728-y.cc: New file.
* gdb.cp/pr10728.exp: New file.
* gdb.cp/Makefile.in (EXECUTABLES): Add pr10728
This commit is contained in:
Chris Moller 2010-02-08 18:27:53 +00:00
parent 99903ae39e
commit 83b10087f4
8 changed files with 117 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
Mon Feb 8 13:17:10 2010 Chris Moller <moller@mollerware.com>
PR gdb/10728
* valarith.c (value_ptrdiff): Added a test for a zero type length,
warn if found, and assume length = 1.
2010-02-08 Chris Moller <cmoller@redhat.com>
PR gdb/9067

9
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,12 @@
Mon Feb 8 13:18:22 2010 Chris Moller <moller@mollerware.com>
PR gdb/10728
* gdb.cp/pr10728-x.h: New file.
* gdb.cp/pr10728-x.cc: New file.
* gdb.cp/pr10728-y.cc: New file.
* gdb.cp/pr10728.exp: New file.
* gdb.cp/Makefile.in (EXECUTABLES): Add pr10728
Mon Feb 8 12:54:54 2010 Chris Moller <moller@mollerware.com>
PR gdb/9067

3
gdb/testsuite/gdb.cp/Makefile.in
View file

@ -4,7 +4,8 @@ srcdir = @srcdir@
EXECUTABLES = ambiguous annota2 anon-union cplusfuncs cttiadd \
derivation inherit local member-ptr method misc \
overload ovldbreak ref-typ ref-typ2 templates userdef virtfunc namespace \
ref-types ref-params method2 pr9594 gdb2495 virtfunc2 pr9067
ref-types ref-params method2 pr9594 gdb2495 virtfunc2 pr9067 \
pr1072
all info install-info dvi install uninstall installcheck check:
@echo "Nothing to be done for $@..."

7
gdb/testsuite/gdb.cp/pr10728-x.cc Normal file
View file

@ -0,0 +1,7 @@
#include "pr10728-x.h"
int main()
{
X* x = y();
return 0; // marker 1
}

9
gdb/testsuite/gdb.cp/pr10728-x.h Normal file
View file

@ -0,0 +1,9 @@
struct Y;
struct X
{
Y* y1;
Y* y2;
};
X* y();

11
gdb/testsuite/gdb.cp/pr10728-y.cc Normal file
View file

@ -0,0 +1,11 @@
#include "pr10728-x.h"
struct Y{};
X* y()
{
static X xx;
static Y yy;
xx.y1 = &yy;
xx.y2 = xx.y1+1;
return &xx;
}

66
gdb/testsuite/gdb.cp/pr10728.exp Normal file
View file

@ -0,0 +1,66 @@
# Copyright 2010 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file is part of the gdb testsuite
set nl "\[\r\n\]+"
if { [skip_cplus_tests] } { continue }
load_lib "cp-support.exp"
set testfile "pr10728"
set srcfile ${testfile}-x.cc
set tfx ${testfile}-x
set tfy ${testfile}-y
set binfile ${objdir}/${subdir}/${testfile}
if { [gdb_compile "${srcdir}/${subdir}/${tfy}.cc" "${tfy}.o" object {c++}] != "" } {
untested pr10728.exp
return -1
}
if { [gdb_compile "${srcdir}/${subdir}/${tfx}.cc" "${tfx}.o" object {debug c++}] != "" } {
untested pr10728.exp
return -1
}
if { [gdb_compile "${tfx}.o ${tfy}.o" ${binfile} executable {debug c++}] != "" } {
untested pr10728.exp
return -1
}
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
if ![runto_main] then {
perror "couldn't run to breakpoint"
continue
}
# set a breakpoint at the return stmt
gdb_breakpoint [gdb_get_line_number "marker 1"]
gdb_continue_to_breakpoint "marker 1"
gdb_test "print x->y2 - x->y1" "warning: Type size unknown, assuming 1\. Try casting to a known type, or void \*\.\[^=\]*= 1"
gdb_exit
return 0

7
gdb/valarith.c
View file

@ -122,6 +122,13 @@ First argument of `-' is a pointer and second argument is neither\n\
an integer nor a pointer of the same type."));
sz = TYPE_LENGTH (check_typedef (TYPE_TARGET_TYPE (type1)));
if (sz == 0)
{
warning (_("Type size unknown, assuming 1. "
"Try casting to a known type, or void *."));
sz = 1;
}
return (value_as_long (arg1) - value_as_long (arg2)) / sz;
}