darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix and improve comment in gdb_remote_download

Browse source 
This patch fixes the current comment in gdb_remote_download, which is
false (the "except if that's already where it is" part).  It also
improves it, by explaining why pass TOFILE through standard_output_file,
even it is an absolute path.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_remote_download): Fix and extend comment.
This commit is contained in:
Simon Marchi 2016-04-13 10:47:29 -04:00
parent fd85a6a1f6
commit 8392fa22d6
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,7 @@
2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
* lib/gdb.exp (gdb_remote_download): Fix and extend comment.
2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
* boards/gdbserver-base.exp (${board}_download): Copy source file to

9
gdb/testsuite/lib/gdb.exp
View file

@ -4211,8 +4211,13 @@ proc gdb_remote_download {dest fromfile {tofile {}}} {
return $destname
} else {
# When the DEST is local, we copy the file to the test directory
# (where the executable is), except if that's already where it is.
# When the DEST is local, we copy the file to the test directory (where
# the executable is).
#
# Note that we pass TOFILE through standard_output_file, regardless of
# whether it is absolute or relative, because we don't want the tests
# to be able to write outside their standard output directory.
set tofile [standard_output_file $tofile]
file copy -force $fromfile $tofile