darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gdb/

Browse source 
Fix crash.
	* valops.c (compare_parameters): Verify TYPE_NFIELDS before
	touching TYPE_FIELD_ARTIFICIAL.

gdb/testsuite/
	* gdb.cp/noparam.exp: New file.
	* gdb.cp/noparam.cc: New file.
This commit is contained in:
Jan Kratochvil 2011-01-29 10:30:20 +00:00
parent 5240d94db3
commit 80b23b6aeb
5 changed files with 62 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2011-01-29 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix crash.
* valops.c (compare_parameters): Verify TYPE_NFIELDS before
touching TYPE_FIELD_ARTIFICIAL.
2011-01-28 Richard Earnshaw <rearnsha@arm.com>
* MAINTAINERS: Move myself from Responsible Maintainers to Authorized

5
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2011-01-29 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.cp/noparam.exp: New file.
* gdb.cp/noparam.cc: New file.
2011-01-28 Pedro Alves <pedro@codesourcery.com>
* gdb.trace/tfile.exp: Test that with no traceframe selected,

29
gdb/testsuite/gdb.cp/noparam.cc Normal file
View file

@ -0,0 +1,29 @@
/* This testcase is part of GDB, the GNU debugger.
Copyright 2011 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
class C
{
public:
static void m () {}
};
int
main ()
{
C::m ();
return 0;
}

21
gdb/testsuite/gdb.cp/noparam.exp Normal file
View file

@ -0,0 +1,21 @@
# Copyright 2011 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if { [prepare_for_testing noparam.exp "noparam" "noparam.cc" {debug c++}] } {
return -1
}
# Check if GDB does not crash.
gdb_test "p C::m (int)" "no member function matches that type instantiation"

2
gdb/valops.c
View file

@ -3097,7 +3097,7 @@ compare_parameters (struct type *t1, struct type *t2, int skip_artificial)
{
int start = 0;
if (TYPE_FIELD_ARTIFICIAL (t1, 0))
if (TYPE_NFIELDS (t1) > 0 && TYPE_FIELD_ARTIFICIAL (t1, 0))
++start;
/* If skipping artificial fields, find the first real field