darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Do not pass NULL for the string in catch_errors

Browse source 
I caught a segmentation fault while running gdb.reverse/sigall-reverse.exp,
in a mingw32 GDB, in this code path. It boils down to the code trying to
strlen () a NULL pointer. I tracked things down and it looks like
record_full_message_wrapper_safe is the only offender.

gdb/ChangeLog:

2015-10-26  Luis Machado  <lgustavo@codesourcery.com>

	* record-full.c (record_full_message_wrapper_safe): Pass empty string to
	catch_errors call instead of NULL.
This commit is contained in:
Luis Machado 2015-10-26 11:17:29 -02:00
parent 48ffa2b8cd
commit 7cc53fba0a
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2015-10-26 Luis Machado <lgustavo@codesourcery.com>
* record-full.c (record_full_message_wrapper_safe): Pass empty string to
catch_errors call instead of NULL.
2015-10-26 Simon Marchi <simon.marchi@polymtl.ca>
* guile/scm-ports.c (ioscm_make_gdb_stdio_port): Pass non-const

2
gdb/record-full.c
View file

@ -667,7 +667,7 @@ record_full_message_wrapper_safe (struct regcache *regcache,
args.regcache = regcache;
args.signal = signal;
return catch_errors (record_full_message_wrapper, &args, NULL,
return catch_errors (record_full_message_wrapper, &args, "",
RETURN_MASK_ALL);
}