* symfile.h (allocate_symtab): Update.
* symfile.c (allocate_symtab): Make 'filename' const. * psymtab.c (add_psymbol_to_bcache): Make 'name' const. (add_psymbol_to_list): Likewise. * psympriv.h (struct partial_symtab) <filename, dirname>: Now const. (add_psymbol_to_list): Update. * mdebugread.c (new_symtab): Make 'name' const. (psymtab_to_symtab_1): Make 'filename' const. * elfread.c (elfstab_offset_sections): Update. * dwarf2read.c (dwarf_decode_lines): Make 'comp_dir' const. (dwarf2_start_subfile): Make 'dirname' and 'comp_dir' const. (psymtab_include_file_name): Update. * dbxread.c (find_stab_function_addr): Make 'filename' const. * buildsym.h (start_subfile): Update. * buildsym.c (start_subfile): Make arguments const.
This commit is contained in:
parent
55e3947383
commit
72b9f47f1e
11 changed files with 45 additions and 24 deletions
|
@ -1,3 +1,22 @@
|
||||||
|
2010-10-01 Tom Tromey <tromey@redhat.com>
|
||||||
|
|
||||||
|
* symfile.h (allocate_symtab): Update.
|
||||||
|
* symfile.c (allocate_symtab): Make 'filename' const.
|
||||||
|
* psymtab.c (add_psymbol_to_bcache): Make 'name' const.
|
||||||
|
(add_psymbol_to_list): Likewise.
|
||||||
|
* psympriv.h (struct partial_symtab) <filename, dirname>: Now
|
||||||
|
const.
|
||||||
|
(add_psymbol_to_list): Update.
|
||||||
|
* mdebugread.c (new_symtab): Make 'name' const.
|
||||||
|
(psymtab_to_symtab_1): Make 'filename' const.
|
||||||
|
* elfread.c (elfstab_offset_sections): Update.
|
||||||
|
* dwarf2read.c (dwarf_decode_lines): Make 'comp_dir' const.
|
||||||
|
(dwarf2_start_subfile): Make 'dirname' and 'comp_dir' const.
|
||||||
|
(psymtab_include_file_name): Update.
|
||||||
|
* dbxread.c (find_stab_function_addr): Make 'filename' const.
|
||||||
|
* buildsym.h (start_subfile): Update.
|
||||||
|
* buildsym.c (start_subfile): Make arguments const.
|
||||||
|
|
||||||
2010-09-30 Ali Lakhia <lakhia@alumni.utexas.net>
|
2010-09-30 Ali Lakhia <lakhia@alumni.utexas.net>
|
||||||
|
|
||||||
* fork-child.c (breakup_args): Fix crash if shell forking is
|
* fork-child.c (breakup_args): Fix crash if shell forking is
|
||||||
|
|
|
@ -523,7 +523,7 @@ make_blockvector (struct objfile *objfile)
|
||||||
the directory in which the file was compiled (or NULL if not known). */
|
the directory in which the file was compiled (or NULL if not known). */
|
||||||
|
|
||||||
void
|
void
|
||||||
start_subfile (char *name, char *dirname)
|
start_subfile (const char *name, const char *dirname)
|
||||||
{
|
{
|
||||||
struct subfile *subfile;
|
struct subfile *subfile;
|
||||||
|
|
||||||
|
|
|
@ -253,7 +253,7 @@ extern void record_block_range (struct block *,
|
||||||
|
|
||||||
extern void really_free_pendings (void *dummy);
|
extern void really_free_pendings (void *dummy);
|
||||||
|
|
||||||
extern void start_subfile (char *name, char *dirname);
|
extern void start_subfile (const char *name, const char *dirname);
|
||||||
|
|
||||||
extern void patch_subfile_names (struct subfile *subfile, char *name);
|
extern void patch_subfile_names (struct subfile *subfile, char *name);
|
||||||
|
|
||||||
|
|
|
@ -1125,7 +1125,7 @@ read_dbx_dynamic_symtab (struct objfile *objfile)
|
||||||
}
|
}
|
||||||
|
|
||||||
static CORE_ADDR
|
static CORE_ADDR
|
||||||
find_stab_function_addr (char *namestring, char *filename,
|
find_stab_function_addr (char *namestring, const char *filename,
|
||||||
struct objfile *objfile)
|
struct objfile *objfile)
|
||||||
{
|
{
|
||||||
struct minimal_symbol *msym;
|
struct minimal_symbol *msym;
|
||||||
|
|
|
@ -1007,10 +1007,10 @@ static struct line_header *(dwarf_decode_line_header
|
||||||
(unsigned int offset,
|
(unsigned int offset,
|
||||||
bfd *abfd, struct dwarf2_cu *cu));
|
bfd *abfd, struct dwarf2_cu *cu));
|
||||||
|
|
||||||
static void dwarf_decode_lines (struct line_header *, char *, bfd *,
|
static void dwarf_decode_lines (struct line_header *, const char *, bfd *,
|
||||||
struct dwarf2_cu *, struct partial_symtab *);
|
struct dwarf2_cu *, struct partial_symtab *);
|
||||||
|
|
||||||
static void dwarf2_start_subfile (char *, char *, char *);
|
static void dwarf2_start_subfile (char *, const char *, const char *);
|
||||||
|
|
||||||
static struct symbol *new_symbol (struct die_info *, struct type *,
|
static struct symbol *new_symbol (struct die_info *, struct type *,
|
||||||
struct dwarf2_cu *);
|
struct dwarf2_cu *);
|
||||||
|
@ -9994,7 +9994,8 @@ psymtab_include_file_name (const struct line_header *lh, int file_index,
|
||||||
char *include_name = fe.name;
|
char *include_name = fe.name;
|
||||||
char *include_name_to_compare = include_name;
|
char *include_name_to_compare = include_name;
|
||||||
char *dir_name = NULL;
|
char *dir_name = NULL;
|
||||||
char *pst_filename;
|
const char *pst_filename;
|
||||||
|
char *copied_name = NULL;
|
||||||
int file_is_pst;
|
int file_is_pst;
|
||||||
|
|
||||||
if (fe.dir_index)
|
if (fe.dir_index)
|
||||||
|
@ -10039,16 +10040,17 @@ psymtab_include_file_name (const struct line_header *lh, int file_index,
|
||||||
pst_filename = pst->filename;
|
pst_filename = pst->filename;
|
||||||
if (!IS_ABSOLUTE_PATH (pst_filename) && pst->dirname != NULL)
|
if (!IS_ABSOLUTE_PATH (pst_filename) && pst->dirname != NULL)
|
||||||
{
|
{
|
||||||
pst_filename = concat (pst->dirname, SLASH_STRING,
|
copied_name = concat (pst->dirname, SLASH_STRING,
|
||||||
pst_filename, (char *)NULL);
|
pst_filename, (char *)NULL);
|
||||||
|
pst_filename = copied_name;
|
||||||
}
|
}
|
||||||
|
|
||||||
file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0;
|
file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0;
|
||||||
|
|
||||||
if (include_name_to_compare != include_name)
|
if (include_name_to_compare != include_name)
|
||||||
xfree (include_name_to_compare);
|
xfree (include_name_to_compare);
|
||||||
if (pst_filename != pst->filename)
|
if (copied_name != NULL)
|
||||||
xfree (pst_filename);
|
xfree (copied_name);
|
||||||
|
|
||||||
if (file_is_pst)
|
if (file_is_pst)
|
||||||
return NULL;
|
return NULL;
|
||||||
|
@ -10078,7 +10080,7 @@ psymtab_include_file_name (const struct line_header *lh, int file_index,
|
||||||
A good testcase for this is mb-inline.exp. */
|
A good testcase for this is mb-inline.exp. */
|
||||||
|
|
||||||
static void
|
static void
|
||||||
dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd,
|
dwarf_decode_lines (struct line_header *lh, const char *comp_dir, bfd *abfd,
|
||||||
struct dwarf2_cu *cu, struct partial_symtab *pst)
|
struct dwarf2_cu *cu, struct partial_symtab *pst)
|
||||||
{
|
{
|
||||||
gdb_byte *line_ptr, *extended_end;
|
gdb_byte *line_ptr, *extended_end;
|
||||||
|
@ -10421,7 +10423,7 @@ dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd,
|
||||||
subfile's name. */
|
subfile's name. */
|
||||||
|
|
||||||
static void
|
static void
|
||||||
dwarf2_start_subfile (char *filename, char *dirname, char *comp_dir)
|
dwarf2_start_subfile (char *filename, const char *dirname, const char *comp_dir)
|
||||||
{
|
{
|
||||||
char *fullname;
|
char *fullname;
|
||||||
|
|
||||||
|
|
|
@ -979,7 +979,7 @@ elf_symfile_init (struct objfile *objfile)
|
||||||
void
|
void
|
||||||
elfstab_offset_sections (struct objfile *objfile, struct partial_symtab *pst)
|
elfstab_offset_sections (struct objfile *objfile, struct partial_symtab *pst)
|
||||||
{
|
{
|
||||||
char *filename = pst->filename;
|
const char *filename = pst->filename;
|
||||||
struct dbx_symfile_info *dbx = objfile->deprecated_sym_stab_info;
|
struct dbx_symfile_info *dbx = objfile->deprecated_sym_stab_info;
|
||||||
struct stab_section_info *maybe = dbx->stab_section_info;
|
struct stab_section_info *maybe = dbx->stab_section_info;
|
||||||
struct stab_section_info *questionable = 0;
|
struct stab_section_info *questionable = 0;
|
||||||
|
|
|
@ -232,7 +232,7 @@ enum block_type { FUNCTION_BLOCK, NON_FUNCTION_BLOCK };
|
||||||
|
|
||||||
static struct block *new_block (enum block_type);
|
static struct block *new_block (enum block_type);
|
||||||
|
|
||||||
static struct symtab *new_symtab (char *, int, struct objfile *);
|
static struct symtab *new_symtab (const char *, int, struct objfile *);
|
||||||
|
|
||||||
static struct linetable *new_linetable (int);
|
static struct linetable *new_linetable (int);
|
||||||
|
|
||||||
|
@ -248,7 +248,7 @@ static void sort_blocks (struct symtab *);
|
||||||
|
|
||||||
static struct partial_symtab *new_psymtab (char *, struct objfile *);
|
static struct partial_symtab *new_psymtab (char *, struct objfile *);
|
||||||
|
|
||||||
static void psymtab_to_symtab_1 (struct partial_symtab *, char *);
|
static void psymtab_to_symtab_1 (struct partial_symtab *, const char *);
|
||||||
|
|
||||||
static void add_block (struct block *, struct symtab *);
|
static void add_block (struct block *, struct symtab *);
|
||||||
|
|
||||||
|
@ -3888,7 +3888,7 @@ mdebug_next_symbol_text (struct objfile *objfile)
|
||||||
The flow of control and even the memory allocation differs. FIXME. */
|
The flow of control and even the memory allocation differs. FIXME. */
|
||||||
|
|
||||||
static void
|
static void
|
||||||
psymtab_to_symtab_1 (struct partial_symtab *pst, char *filename)
|
psymtab_to_symtab_1 (struct partial_symtab *pst, const char *filename)
|
||||||
{
|
{
|
||||||
bfd_size_type external_sym_size;
|
bfd_size_type external_sym_size;
|
||||||
bfd_size_type external_pdr_size;
|
bfd_size_type external_pdr_size;
|
||||||
|
@ -4671,7 +4671,7 @@ sort_blocks (struct symtab *s)
|
||||||
linenumbers MAXLINES we'll put in it */
|
linenumbers MAXLINES we'll put in it */
|
||||||
|
|
||||||
static struct symtab *
|
static struct symtab *
|
||||||
new_symtab (char *name, int maxlines, struct objfile *objfile)
|
new_symtab (const char *name, int maxlines, struct objfile *objfile)
|
||||||
{
|
{
|
||||||
struct symtab *s = allocate_symtab (name, objfile);
|
struct symtab *s = allocate_symtab (name, objfile);
|
||||||
|
|
||||||
|
|
|
@ -73,7 +73,7 @@ struct partial_symtab
|
||||||
|
|
||||||
/* Name of the source file which this partial_symtab defines */
|
/* Name of the source file which this partial_symtab defines */
|
||||||
|
|
||||||
char *filename;
|
const char *filename;
|
||||||
|
|
||||||
/* Full path of the source file. NULL if not known. */
|
/* Full path of the source file. NULL if not known. */
|
||||||
|
|
||||||
|
@ -81,7 +81,7 @@ struct partial_symtab
|
||||||
|
|
||||||
/* Directory in which it was compiled, or NULL if we don't know. */
|
/* Directory in which it was compiled, or NULL if we don't know. */
|
||||||
|
|
||||||
char *dirname;
|
const char *dirname;
|
||||||
|
|
||||||
/* Information about the object file from which symbols should be read. */
|
/* Information about the object file from which symbols should be read. */
|
||||||
|
|
||||||
|
@ -156,7 +156,7 @@ extern void sort_pst_symbols (struct partial_symtab *);
|
||||||
/* Add any kind of symbol to a psymbol_allocation_list. */
|
/* Add any kind of symbol to a psymbol_allocation_list. */
|
||||||
|
|
||||||
extern const
|
extern const
|
||||||
struct partial_symbol *add_psymbol_to_list (char *, int, int, domain_enum,
|
struct partial_symbol *add_psymbol_to_list (const char *, int, int, domain_enum,
|
||||||
enum address_class,
|
enum address_class,
|
||||||
struct psymbol_allocation_list *,
|
struct psymbol_allocation_list *,
|
||||||
long, CORE_ADDR,
|
long, CORE_ADDR,
|
||||||
|
|
|
@ -1368,7 +1368,7 @@ psymbol_bcache_full (struct partial_symbol *sym,
|
||||||
different domain (or address) is possible and correct. */
|
different domain (or address) is possible and correct. */
|
||||||
|
|
||||||
static const struct partial_symbol *
|
static const struct partial_symbol *
|
||||||
add_psymbol_to_bcache (char *name, int namelength, int copy_name,
|
add_psymbol_to_bcache (const char *name, int namelength, int copy_name,
|
||||||
domain_enum domain,
|
domain_enum domain,
|
||||||
enum address_class class,
|
enum address_class class,
|
||||||
long val, /* Value as a long */
|
long val, /* Value as a long */
|
||||||
|
@ -1465,7 +1465,7 @@ append_psymbol_to_list (struct psymbol_allocation_list *list,
|
||||||
cache. */
|
cache. */
|
||||||
|
|
||||||
const struct partial_symbol *
|
const struct partial_symbol *
|
||||||
add_psymbol_to_list (char *name, int namelength, int copy_name,
|
add_psymbol_to_list (const char *name, int namelength, int copy_name,
|
||||||
domain_enum domain,
|
domain_enum domain,
|
||||||
enum address_class class,
|
enum address_class class,
|
||||||
struct psymbol_allocation_list *list,
|
struct psymbol_allocation_list *list,
|
||||||
|
|
|
@ -2724,7 +2724,7 @@ deduce_language_from_filename (const char *filename)
|
||||||
*/
|
*/
|
||||||
|
|
||||||
struct symtab *
|
struct symtab *
|
||||||
allocate_symtab (char *filename, struct objfile *objfile)
|
allocate_symtab (const char *filename, struct objfile *objfile)
|
||||||
{
|
{
|
||||||
struct symtab *symtab;
|
struct symtab *symtab;
|
||||||
|
|
||||||
|
|
|
@ -374,7 +374,7 @@ extern struct symfile_segment_data *default_symfile_segments (bfd *abfd);
|
||||||
extern bfd_byte *default_symfile_relocate (struct objfile *objfile,
|
extern bfd_byte *default_symfile_relocate (struct objfile *objfile,
|
||||||
asection *sectp, bfd_byte *buf);
|
asection *sectp, bfd_byte *buf);
|
||||||
|
|
||||||
extern struct symtab *allocate_symtab (char *, struct objfile *);
|
extern struct symtab *allocate_symtab (const char *, struct objfile *);
|
||||||
|
|
||||||
extern void add_symtab_fns (const struct sym_fns *);
|
extern void add_symtab_fns (const struct sym_fns *);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue