darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Optimize PC-relative offset overflow check

Browse source 
* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Optimize
	PC-relative offset overflow check.
This commit is contained in:
H.J. Lu 2014-11-21 12:12:30 -08:00
parent 9d58518888
commit 5974eba65b
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bfd/ChangeLog
View file

@ -1,3 +1,8 @@
2014-11-21 H.J. Lu <hongjiu.lu@intel.com>
* elf64-x86-64.c (elf_x86_64_finish_dynamic_symbol): Optimize
PC-relative offset overflow check.
2014-11-21 Alexander Cherepanov <cherepan@mccme.ru>
PR binutils/17512

8
bfd/elf64-x86-64.c
View file

@ -4749,8 +4749,7 @@ elf_x86_64_finish_dynamic_symbol (bfd *output_bfd,
bfd_byte *loc;
asection *plt, *gotplt, *relplt, *resolved_plt;
const struct elf_backend_data *bed;
bfd_boolean gotplt_after_plt;
int32_t plt_got_pcrel_offset;
bfd_vma plt_got_pcrel_offset;
/* When building a static executable, use .iplt, .igot.plt and
.rela.iplt sections for STT_GNU_IFUNC symbols. */
@ -4864,10 +4863,7 @@ elf_x86_64_finish_dynamic_symbol (bfd *output_bfd,
- plt_got_insn_size);
/* Check PC-relative offset overflow in PLT entry. */
gotplt_after_plt = (gotplt->output_section->vma
> resolved_plt->output_section->vma);
if ((gotplt_after_plt && plt_got_pcrel_offset < 0)
|| (!gotplt_after_plt && plt_got_pcrel_offset > 0))
if ((plt_got_pcrel_offset + 0x80000000) > 0xffffffff)
info->callbacks->einfo (_("%F%B: PC-relative offset overflow in PLT entry for `%s'\n"),
output_bfd, h->root.root.string);