darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gdb.base/interrupt.exp: Fix race

Browse source 
Working on splitting gdb and inferior output handling in this test, I
noticed a race that happens to be masked out today.

The test sends "a\n" to the inferior, and then inferior echoes back
"a\n".

If expect manages to read only the first "a\r\n" into its buffer, then
this matches:

    -re "^a\r\n(|a\r\n)$" {

and leaves the second "a\r\n" in output.

Then the next test that processes inferior I/O sends "data\n", and expects:

    -re "^(\r\n|)data\r\n(|data\r\n)$"

which fails given the anchor and given "a\r\n" is still in the buffer.

This is masked today because the test relies on inferior I/O being
done on GDB's terminal, and there are tested GDB commands in between,
which consume the "a\r\n" that was left in the output.

We don't support SunOS4 anymore, so just remove the workaround.

gdb/testsuite/ChangeLog
2015-04-07  Pedro Alves  <palves@redhat.com>

	* gdb.base/interrupt.exp: Don't handle the case of the inferior
	output appearing once only.
This commit is contained in:
Pedro Alves 2015-04-07 18:19:29 +01:00
parent a97902de74
commit 508a3ddf63
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2015-04-07 Pedro Alves <palves@redhat.com>
* gdb.base/interrupt.exp: Don't handle the case of the inferior
output appearing once only.
2015-04-07 Pedro Alves <palves@redhat.com>
* gdb.trace/actions.exp: Use gdb_breakpoint instead of gdb_test

10
gdb/testsuite/gdb.base/interrupt.exp
View file

@ -58,12 +58,10 @@ if ![file exists $binfile] then {
eof { fail "run (eof)" }
}
# This should appear twice, once for the echo and once for the
# program's output. Under dejagnu (but not interactively) for
# SunOS4, it only appears once. Don't worry about it, I imagine
# dejagnu has just done something to the tty modes.
# program's output.
send_gdb "a\n"
gdb_expect {
-re "^a\r\n(|a\r\n)$" {
-re "^a\r\na\r\n$" {
pass "child process ate our char"
}
timeout { fail "echo a (timeout)" }
@ -155,7 +153,7 @@ if ![file exists $binfile] then {
# but the success is spurious. Need to provide the right reg.expr.
# here.
gdb_expect {
-re "^(\r\n|)data\r\n(|data\r\n)$" { pass "echo data" }
-re "^(\r\n|)data\r\ndata\r\n$" { pass "echo data" }
-re "Undefined command.*$gdb_prompt " { fail "echo data" }
timeout { fail "echo data (timeout)" }
eof { fail "echo data (eof)" }
@ -184,7 +182,7 @@ if ![file exists $binfile] then {
# We should be back in the loop.
send_gdb "more data\n"
gdb_expect {
-re "^(\r\n|)more data\r\n(|more data\r\n)$" { pass "echo more data" }
-re "^(\r\n|)more data\r\nmore data\r\n$" { pass "echo more data" }
timeout { fail "echo more data (timeout)" }
eof { fail "echo more data (eof)" }
}