darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

2001-03-20 Daniel Berlin <dberlin@redhat.com>

Browse source 
* symtab.c (completion_list_add_name): Remove duplicate string checks,
	readline already does this, and it's much faster at it, too.
This commit is contained in:
Daniel Berlin 2001-04-01 19:50:50 +00:00
parent ba8629a96e
commit 4e4f46a17d
2 changed files with 5 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2001-03-20 Daniel Berlin <dberlin@redhat.com>
* symtab.c (completion_list_add_name): Remove duplicate string checks,
readline already does this, and it's much faster at it, too.
2001-04-01 Eli Zaretskii <eliz@is.elta.co.il>
* go32-nat.c: Minor tweaks, to pacify the ari script.

24
gdb/symtab.c
View file

@ -2844,17 +2844,6 @@ completion_list_add_name (char *symname, char *sym_text, int sym_text_len,
return;
}
/* Clip any symbol names that we've already considered. (This is a
time optimization) */
for (i = 0; i < return_val_index; ++i)
{
if (STREQ (symname, return_val[i]))
{
return;
}
}
/* We have a match for a completion, so add SYMNAME to the current list
of matches. Note that the name is moved to freshly malloc'd space. */
@ -2880,19 +2869,6 @@ completion_list_add_name (char *symname, char *sym_text, int sym_text_len,
strcat (new, symname);
}
/* Recheck for duplicates if we intend to add a modified symbol. */
if (word != sym_text)
{
for (i = 0; i < return_val_index; ++i)
{
if (STREQ (new, return_val[i]))
{
xfree (new);
return;
}
}
}
if (return_val_index + 3 > return_val_size)
{
newsize = (return_val_size *= 2) * sizeof (char *);