darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gas: blackfin: reject invalid register destinations for vector add/sub

Browse source 
The destination registers with vector add/sub insns must be different,
so make sure gas rejects attempt to write these.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Mike Frysinger 2011-03-24 06:17:47 +00:00
parent 67171547aa
commit 2dd0dc9418
5 changed files with 30 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gas/ChangeLog
View file

@ -1,3 +1,10 @@
2011-03-24 Mike Frysinger <vapier@gentoo.org>
* config/bfin-parse.y (dual 32bit add/sub): Return yyerror when dest
reg $1 is the same as dest reg $7.
(quad 16bit add/sub): Return yyerror when dest reg $1 is the same as
dest reg $7.
2011-03-24 Mike Frysinger <vapier@gentoo.org>
* config/bfin-parse.y (check_macfuncs): Clarify error message when

7
gas/config/bfin-parse.y
View file

@ -1,5 +1,5 @@
/* bfin-parse.y ADI Blackfin parser
Copyright 2005, 2006, 2007, 2008, 2009, 2010
Copyright 2005, 2006, 2007, 2008, 2009, 2010, 2011
Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@ -898,6 +898,9 @@ asm_1:
| REG ASSIGN REG_A PLUS REG_A COMMA REG ASSIGN REG_A MINUS REG_A amod1
{
if (REG_SAME ($1, $7))
return yyerror ("Resource conflict in dest reg");
if (IS_DREG ($1) && IS_DREG ($7) && !REG_SAME ($3, $5)
&& IS_A1 ($9) && !IS_A1 ($11))
{
@ -941,6 +944,8 @@ asm_1:
if (!IS_DREG ($1) || !IS_DREG ($3) || !IS_DREG ($5) || !IS_DREG ($7))
return yyerror ("Dregs expected");
if (REG_SAME ($1, $7))
return yyerror ("Resource conflict in dest reg");
if ($4.r0 == 1 && $10.r0 == 2)
{

5
gas/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2011-03-24 Mike Frysinger <vapier@gentoo.org>
* gas/bfin/expected_errors.s: Add invalid vector add/sub insn tests.
* gas/bfin/expected_errors.l: Add new error messages.
2011-03-24 Mike Frysinger <vapier@gentoo.org>
* gas/bfin/16bit_illegals.d, gas/bfin/16bit_illegals.s: Delete.

5
gas/testsuite/gas/bfin/expected_errors.l
View file

@ -95,3 +95,8 @@
.*:120: Error: Destination Dregs \(full\) must differ by one.
.*:121: Error: Destination Dregs \(half\) must match.
.*:122: Error: Destination Dreg sizes \(full or half\) must match.
.*:124: Error: Resource conflict in dest reg.
.*:125: Error: Differing source registers.
.*:126: Error: Resource conflict in dest reg.
.*:127: Error: Differing source registers.
.*:129: Error: Register mismatch.

7
gas/testsuite/gas/bfin/expected_errors.s
View file

@ -120,3 +120,10 @@
R0 = A0, R3 = A1;
R0.L = A0, R1.H = A1;
R0 = A0, R1.H = A1;
R0 = R1 +|+ R2, R0 = R1 -|- R2;
R0 = R4 +|+ R5, R1 = R6 -|- R7;
R1 = R3 +|- R7, R1 = R3 -|+ R7;
R7 = R3 +|- R4, R1 = R1 -|+ R2;
R0 = R3 + R4, R1 = R5 - R6;