darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gdb_test_multiple: return -1 on internal error

Browse source 
gdb_test_multiple is supposed to return -1 on internal error:

  # Returns:
  #    1 if the test failed, according to a built-in failure pattern
  #    0 if only user-supplied patterns matched
  #   -1 if there was an internal error.

But alas, that's broken, it returns success...  It looks like the code
is assuming an earlier 'set result -1' is still in effect, but
'result' is set to 0 at the end, just before we call gdb_expect:

    set result 0
    set code [catch {gdb_expect $code} string]

gdb/testsuite/
2015-03-02  Pedro Alves  <palves@redhat.com>

	* lib/gdb.exp (gdb_test_multiple) <internal error>: Set result to
	-1.
This commit is contained in:
Pedro Alves 2015-03-02 20:05:25 +00:00
parent 2c7b626cee
commit 28054d694f
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2015-03-02 Pedro Alves <palves@redhat.com>
* lib/gdb.exp (gdb_test_multiple) <internal error>: Set result to
-1.
2015-03-02 Andreas Arnez <arnez@linux.vnet.ibm.com> 2015-03-02 Andreas Arnez <arnez@linux.vnet.ibm.com>
* gdb.arch/s390-vregs.exp: New test. * gdb.arch/s390-vregs.exp: New test.

1
gdb/testsuite/lib/gdb.exp
View file

@ -808,6 +808,7 @@ proc gdb_test_multiple { command message user_code } {
-re ".*A problem internal to GDB has been detected" { -re ".*A problem internal to GDB has been detected" {
fail "$message (GDB internal error)" fail "$message (GDB internal error)"
gdb_internal_error_resync gdb_internal_error_resync
set result -1
} }
-re "\\*\\*\\* DOSEXIT code.*" { -re "\\*\\*\\* DOSEXIT code.*" {
if { $message != "" } { if { $message != "" } {