darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

PR7044

Browse source 
* dlltool.c (run): Use formatting string to avoid compile time
        warning.
        (gen_exp_file): Check return value from fread.
        * windmc.c (main): Check return value from fread.
This commit is contained in:
Nick Clifton 2008-11-25 08:48:49 +00:00
parent bcae43427d
commit 20359e080a
3 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
binutils/ChangeLog
View file

@ -1,3 +1,11 @@
2008-11-25 Nick Clifton <nickc@redhat.com>
PR7044
* dlltool.c (run): Use formatting string to avoid compile time
warning.
(gen_exp_file): Check return value from fread.
* windmc.c (main): Check return value from fread.
2008-11-21 Sterling Augustine <sterling@tensilica.com>
* MAINTAINERS: Take over from Bob Wilson as Xtensa maintainer.

7
binutils/dlltool.c
View file

@ -1213,7 +1213,7 @@ run (const char *what, char *args)
if (pid == -1)
{
inform (strerror (errno));
inform ("%s", strerror (errno));
fatal (errmsg_fmt, errmsg_arg);
}
@ -1998,7 +1998,7 @@ gen_exp_file (void)
bfd_vma addr;
bfd_vma need[PAGE_SIZE];
bfd_vma page_addr;
int numbytes;
bfd_size_type numbytes;
int num_entries;
bfd_vma *copy;
int j;
@ -2010,7 +2010,8 @@ gen_exp_file (void)
numbytes = ftell (base_file);
fseek (base_file, 0, SEEK_SET);
copy = xmalloc (numbytes);
fread (copy, 1, numbytes, base_file);
if (fread (copy, 1, numbytes, base_file) < numbytes)
fatal (_("failed to read the number of entries from base file"));
num_entries = numbytes / sizeof (bfd_vma);

5
binutils/windmc.c
View file

@ -1144,7 +1144,7 @@ main (int argc, char **argv)
unichar *u;
rc_uint_type ul;
char *buff;
long flen;
bfd_size_type flen;
FILE *fp = fopen (input_filename, "rb");
if (!fp)
@ -1155,7 +1155,8 @@ main (int argc, char **argv)
fseek (fp, 0, SEEK_SET);
buff = malloc (flen + 3);
memset (buff, 0, flen + 3);
fread (buff, 1, flen, fp);
if (fread (buff, 1, flen, fp) < flen)
fatal (_("unable to read contents of %s"), input_filename);
fclose (fp);
if (mcset_text_in_is_unicode != 1)
{