darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* elfxx-mips.c (_bfd_mips_elf_section_processing): Warn and

Browse source 
stop processing of options if one of invalid size is
encountered.
(_bfd_mips_elf_section_from_shdr): Likewise.
(_bfd_mips_elf_fake_sections): Reset the type of empty special
sections.
This commit is contained in:
Maciej W. Rozycki 2005-05-26 18:51:11 +00:00
parent 7c06efaa64
commit 1bc8074d91
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bfd/ChangeLog
View file

@ -1,3 +1,13 @@
2005-05-26 Mark Kettenis <kettenis@gnu.org>
Maciej W. Rozycki <macro@linux-mips.org>
* elfxx-mips.c (_bfd_mips_elf_section_processing): Warn and
stop processing of options if one of invalid size is
encountered.
(_bfd_mips_elf_section_from_shdr): Likewise.
(_bfd_mips_elf_fake_sections): Reset the type of empty special
sections.
2005-05-26 Richard Henderson <rth@redhat.com>
* elf64-alpha.c (struct alpha_elf_link_hash_entry): Remove

22
bfd/elfxx-mips.c
View file

@ -4987,6 +4987,13 @@ _bfd_mips_elf_section_processing (bfd *abfd, Elf_Internal_Shdr *hdr)
bfd_mips_elf_swap_options_in (abfd, (Elf_External_Options *) l,
&intopt);
if (intopt.size < sizeof (Elf_External_Options))
{
(*_bfd_error_handler)
(_("%B: Warning: bad `%s' option size %u smaller than its header"),
abfd, MIPS_ELF_OPTIONS_SECTION_NAME (abfd), intopt.size);
break;
}
if (ABI_64_P (abfd) && intopt.kind == ODK_REGINFO)
{
bfd_byte buf[8];
@ -5201,6 +5208,13 @@ _bfd_mips_elf_section_from_shdr (bfd *abfd,
bfd_mips_elf_swap_options_in (abfd, (Elf_External_Options *) l,
&intopt);
if (intopt.size < sizeof (Elf_External_Options))
{
(*_bfd_error_handler)
(_("%B: Warning: bad `%s' option size %u smaller than its header"),
abfd, MIPS_ELF_OPTIONS_SECTION_NAME (abfd), intopt.size);
break;
}
if (ABI_64_P (abfd) && intopt.kind == ODK_REGINFO)
{
Elf64_Internal_RegInfo intreg;
@ -5239,8 +5253,10 @@ bfd_boolean
_bfd_mips_elf_fake_sections (bfd *abfd, Elf_Internal_Shdr *hdr, asection *sec)
{
register const char *name;
unsigned int sh_type;
name = bfd_get_section_name (abfd, sec);
sh_type = hdr->sh_type;
if (strcmp (name, ".liblist") == 0)
{
@ -5342,6 +5358,12 @@ _bfd_mips_elf_fake_sections (bfd *abfd, Elf_Internal_Shdr *hdr, asection *sec)
hdr->sh_entsize = 8;
}
/* In the unlikely event a special section is empty it has to lose its
special meaning. This may happen e.g. when using `strip' with the
"--only-keep-debug" option. */
if (sec->size > 0 && !(sec->flags & SEC_HAS_CONTENTS))
hdr->sh_type = sh_type;
/* The generic elf_fake_sections will set up REL_HDR using the default
kind of relocations. We used to set up a second header for the
non-default kind of relocations here, but only NewABI would use