darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ARI cleanup.

Browse source 
* xtensa-tdep.c (xtensa_register_type): Use xstrprintf instead of
	sprintf. Simplify code and avoid loosing memory.
	(xtensa_register_reggroup_p): Extract assignment out of IF clause.
	(call0_frame_cache): Remove && operator from end of line.
This commit is contained in:
Pierre Muller 2011-04-19 07:16:42 +00:00
parent 74fc483f27
commit 1448a0a258
2 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,11 @@
2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
ARI cleanup.
* xtensa-tdep.c (xtensa_register_type): Use xstrprintf instead of
sprintf. Simplify code and avoid loosing memory.
(xtensa_register_reggroup_p): Extract assignment out of IF clause.
(call0_frame_cache): Remove && operator from end of line.
2011-04-17 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix libraries displacement if they change whether they were prelinked.

16
gdb/xtensa-tdep.c
View file

@ -318,15 +318,14 @@ xtensa_register_type (struct gdbarch *gdbarch, int regnum)
if (tp == NULL)
{
char *name = xmalloc (16);
char *name = xstrprintf ("int%d", size * 8);
tp = xmalloc (sizeof (struct ctype_cache));
tp->next = tdep->type_entries;
tdep->type_entries = tp;
tp->size = size;
sprintf (name, "int%d", size * 8);
tp->virtual_type
= arch_integer_type (gdbarch, size * 8, 1, xstrdup (name));
= arch_integer_type (gdbarch, size * 8, 1, name);
xfree (name);
}
reg->ctype = tp->virtual_type;
@ -843,7 +842,8 @@ xtensa_register_reggroup_p (struct gdbarch *gdbarch,
if (group == restore_reggroup)
return (regnum < gdbarch_num_regs (gdbarch)
&& (reg->flags & SAVE_REST_FLAGS) == SAVE_REST_VALID);
if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0)
cp_number = xtensa_coprocessor_register_group (group);
if (cp_number >= 0)
return rg & (xtRegisterGroupCP0 << cp_number);
else
return 1;
@ -2715,9 +2715,9 @@ call0_frame_cache (struct frame_info *this_frame,
too bad. */
int i;
for (i = 0;
(i < C0_NREGS) &&
(i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
for (i = 0;
(i < C0_NREGS)
&& (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
++i);
if (i >= C0_NREGS && cache->c0.c0_rt[C0_RA].fr_reg == C0_RA)
i = C0_RA;