thread support broken on ppc-aix.
Thread support got broken when adding 64bit support on ppc-aix. Upon digging further, I found that the following patch... | * gdb_ptrace.h: Use ptrace64 instead of ptrace if HAVE_PTRACE64 | is defined. | * rs6000-nat.c: Check for __ld_info64_ if compiling 64 BIT gdb. | (rs6000_ptrace32): Call ptrace64 instead of ptrace if present. | (rs6000_ptrace64): Call ptace64 instead of ptracex if present. | * configure.ac: Check for ptrace64. | * configure, config.in: Regenerate. ... is responsible for this regression: (gdb) x /x &__n_pthreads 0xf06a8258 <__n_pthreads>: Cannot access memory at address 0xf06a8258 Prior to the patch, we have: (gdb) x /x &__n_pthreads 0xf06a8258 <__n_pthreads>: 0x00000003 The problem occurs inside rs6000_ptrace32, while calling ptrace64. The address is given to rs6000_ptrace32 as an "int *", while ptrace64 takes a "long long". The cast causes the address to be sign-extended, which results in GDB trying to read the wrong address. This patch fixes the issue by casting the address to a "uintptr_t" instead, and letting the compiler do the implicit conversion to "long long" in the function call. gdb/ChangeLog: * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t" instead of "long long" in call to ptrace64.
This commit is contained in:
parent
489d4f4d01
commit
11cb8762fc
2 changed files with 6 additions and 1 deletions
|
@ -1,3 +1,8 @@
|
|||
2013-08-29 Joel Brobecker <brobecker@adacore.com>
|
||||
|
||||
* rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
|
||||
instead of "long long" in call to ptrace64.
|
||||
|
||||
2013-08-29 Andrew Burgess <aburgess@broadcom.com>
|
||||
|
||||
* mi/mi-interp.c (mi_command_loop): Change signature to match
|
||||
|
|
|
@ -132,7 +132,7 @@ static int
|
|||
rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf)
|
||||
{
|
||||
#ifdef HAVE_PTRACE64
|
||||
int ret = ptrace64 (req, id, (long long) addr, data, buf);
|
||||
int ret = ptrace64 (req, id, (uintptr_t) addr, data, buf);
|
||||
#else
|
||||
int ret = ptrace (req, id, (int *)addr, data, buf);
|
||||
#endif
|
||||
|
|
Loading…
Reference in a new issue