darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

don't let hexify call strlen

Browse source 
hexify had the same issue as bin2hex; and the fix is the same.

2014-02-12  Tom Tromey  <tromey@redhat.com>

	* common/rsp-low.c (hexify): Never take strlen of argument.

2014-02-12  Tom Tromey  <tromey@redhat.com>

	* remote-utils.c (monitor_output): Pass explicit length to
	hexify.
This commit is contained in:
Tom Tromey 2014-01-18 19:25:57 -07:00
parent 9f1b45b0da
commit 0a822afbcd
4 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2014-02-12 Tom Tromey <tromey@redhat.com>
* common/rsp-low.c (hexify): Never take strlen of argument.
2014-02-12 Tom Tromey <tromey@redhat.com>
* common/rsp-low.c (bin2hex): Never take strlen of argument.

4
gdb/common/rsp-low.c
View file

@ -177,10 +177,6 @@ hexify (char *hex, const char *bin, int count)
{
int i;
/* May use a length, or a nul-terminated string as input. */
if (count == 0)
count = strlen (bin);
for (i = 0; i < count; i++)
{
*hex++ = tohex ((*bin >> 4) & 0xf);

5
gdb/gdbserver/ChangeLog
View file

@ -1,3 +1,8 @@
2014-02-12 Tom Tromey <tromey@redhat.com>
* remote-utils.c (monitor_output): Pass explicit length to
hexify.
2014-02-12 Tom Tromey <tromey@redhat.com>
* tracepoint.c: Include rsp-low.h.

5
gdb/gdbserver/remote-utils.c
View file

@ -1558,10 +1558,11 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
void
monitor_output (const char *msg)
{
char *buf = xmalloc (strlen (msg) * 2 + 2);
int len = strlen (msg);
char *buf = xmalloc (len * 2 + 2);
buf[0] = 'O';
hexify (buf + 1, msg, 0);
hexify (buf + 1, msg, len);
putpkt (buf);
free (buf);