darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix -Wpointer-sign warning in sol-thread.c

Browse source 
This fixes a couple of compiler warnings in rw_common when calling
target_read_memory/target_write_memory due to the type of parameter
"buf" (char *) not matching what these function expect (gdb_byte *).

gdb/ChangeLog:

        * sol-thread.c (rw_common): Change type of parameter "buf"
        to "gdb_byte *".
        (ps_pdwrite, ps_ptwrite): Cast parameter "buf" in call to
        rw_common to "gdb_byte *" instead of "char *".
This commit is contained in:
Joel Brobecker 2013-04-30 11:52:13 +00:00
parent 5812197ca1
commit 019c1128ac
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -2,6 +2,13 @@
* MAINTAINERS (Write After Approval): Add myself to the list.
2013-04-30 Joel Brobecker <brobecker@adacore.com>
* sol-thread.c (rw_common): Change type of parameter "buf"
to "gdb_byte *".
(ps_pdwrite, ps_ptwrite): Cast parameter "buf" in call to
rw_common to "gdb_byte *" instead of "char *".
2013-04-30 Joel Brobecker <brobecker@adacore.com>
* sol-thread.c (info_cb) [ti.ti_startfunc != 0]: Change type

6
gdb/sol-thread.c
View file

@ -782,7 +782,7 @@ ps_pglobal_lookup (gdb_ps_prochandle_t ph, const char *ld_object_name,
static ps_err_e
rw_common (int dowrite, const struct ps_prochandle *ph, gdb_ps_addr_t addr,
char *buf, int size)
gdb_byte *buf, int size)
{
int ret;
struct cleanup *old_chain;
@ -831,7 +831,7 @@ ps_err_e
ps_pdwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr,
gdb_ps_write_buf_t buf, gdb_ps_size_t size)
{
return rw_common (1, ph, addr, (char *) buf, size);
return rw_common (1, ph, addr, (gdb_byte *) buf, size);
}
/* Copies SIZE bytes from target process .text segment to debugger memory. */
@ -849,7 +849,7 @@ ps_err_e
ps_ptwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr,
gdb_ps_write_buf_t buf, gdb_ps_size_t size)
{
return rw_common (1, ph, addr, (char *) buf, size);
return rw_common (1, ph, addr, (gdb_byte *) buf, size);
}
/* Get general-purpose registers for LWP. */