old-cross-binutils/sim/testsuite/ChangeLog

307 lines
8.8 KiB
Text
Raw Normal View History

2015-04-13 Hans-Peter Nilsson <hp@axis.com>
* sim-defs.exp (sim_init): Unset target ldscript here.
2015-03-30 Mike Frysinger <vapier@gentoo.org>
* configure.ac: Add d10v-*-elf.
* configure: Regenerate.
2015-03-29 Mike Frysinger <vapier@gentoo.org>
* lib/sim-defs.exp (run_sim_test): Declare seen_output as 0. When
the test has an output keyword, set it to 1. Set default output only
when seen_output is 0.
2015-03-29 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
2015-03-28 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
2015-03-28 James Bowman <james.bowman@ftdichip.com>
* configure: Regenerate.
2014-03-10 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
2014-03-04 Mike Frysinger <vapier@gentoo.org>
* common/bits-gen.c (main): Change to new style prototype.
2013-09-23 Alan Modra <amodra@gmail.com>
* configure: Regenerate.
Define PACKAGE macro in all sims' config.h. Some of the common includes in include/gdb such as callback.h include bfd.h. But there was a recent change in bfd-in.h to require that config.h be included before bfd.h can be included: /* PR 14072: Ensure that config.h is included first. */ #if !defined PACKAGE && !defined PACKAGE_VERSION #error config.h must be included before this header #endif PACKAGE_VERSION is always defined by default by the AC_INIT autoconf macro, but PACKAGE isn't. This patch updates the SIM_AC_COMMON macro to define it, and then regenerates all configure scripts and config.in files. sim/common/changeLog: * acinclude.m4 (SIM_AC_COMMON): Define PACKAGE. * config.in, configure: Regenerate. sim/ChangeLog: * configure: Regenerate. sim/arm/ChangeLog: * config.in, configure: Regenerate. sim/avr/ChangeLog: * config.in, configure: Regenerate. sim/bfin/ChangeLog: * config.in, configure: Regenerate. sim/cr16/ChangeLog: * config.in, configure: Regenerate. sim/cris/ChangeLog: * config.in, configure: Regenerate. sim/d10v/ChangeLog: * config.in, configure: Regenerate. sim/erc32/ChangeLog: * config.in, configure: Regenerate. sim/frv/ChangeLog: * config.in, configure: Regenerate. sim/h8300/ChangeLog: * config.in, configure: Regenerate. sim/iq2000/ChangeLog: * config.in, configure: Regenerate. sim/lm32/ChangeLog: * config.in, configure: Regenerate. sim/m32c/ChangeLog: * config.in, configure: Regenerate. sim/m32r/ChangeLog: * config.in, configure: Regenerate. sim/m68hc11/ChangeLog: * config.in, configure: Regenerate. sim/mcore/ChangeLog: * config.in, configure: Regenerate. sim/microblaze/ChangeLog: * config.in, configure: Regenerate. sim/mips/ChangeLog: * config.in, configure: Regenerate. sim/mn10300/ChangeLog: * config.in, configure: Regenerate. sim/moxie/ChangeLog: * config.in, configure: Regenerate. sim/ppc/ChangeLog: * configure: Regenerate. sim/rl78/ChangeLog: * config.in, configure: Regenerate. sim/rx/ChangeLog: * config.in, configure: Regenerate. sim/sh/ChangeLog: * config.in, configure: Regenerate. sim/sh64/ChangeLog: * config.in, configure: Regenerate. sim/v850/ChangeLog: * config.in, configure: Regenerate. sim/testsuite/ChangeLog: * configure: Regenerate.
2012-06-15 17:20:10 +00:00
2012-06-15 Joel Brobecker <brobecker@adacore.com>
* configure: Regenerate.
2012-03-24 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
2012-03-19 03:51:09 +00:00
2012-03-18 Mike Frysinger <vapier@gentoo.org>
* .gitignore: New file.
2011-10-17 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate after bfin testsuite update.
2011-05-16 Mike Frysinger <vapier@gentoo.org>
* lib/sim-defs.exp: Support cc tag in test files.
(run_sim_test): Support global_cc_options in boards files. Convert
assembler options into compiler options (c_as_options) with -Wa.
Convert linker options into compiler options (c_ld_options) with -Wl.
Compile .c and .S files into .x programs.
2011-05-04 Joseph Myers <joseph@codesourcery.com>
* configure: Regenerate.
2010-04-26 Mike Frysinger <vapier@gentoo.org>
* Makefile.in (arch): Set to @sim_arch@.
* configure.ac: Delete arch logic and include ../configure.tgt.
* configure: Regenerated.
* lib/sim-defs.exp (sim_run): Default sim to ../arch/run.
Regenerate tree using Autoconf 2.64 and Automake 1.11. config/: * override.m4 (_GCC_AUTOCONF_VERSION): Bump to 2.64. /: * configure: Regenerate. etc/: * configure: Regenerate. sim/common/: * config.in: Regenerate. * configure: Likewise. sim/iq2000/: * config.in: Regenerate. * configure: Likewise. sim/d10v/: * config.in: Regenerate. * configure: Likewise. sim/igen/: * config.in: Regenerate. * configure: Likewise. sim/m32r/: * config.in: Regenerate. * configure: Likewise. sim/frv/: * config.in: Regenerate. * configure: Likewise. sim/: * avr/config.in: Regenerate. * avr/configure: Likewise. * configure: Likewise. * cris/config.in: Likewise. * cris/configure: Likewise. sim/h8300/: * config.in: Regenerate. * configure: Likewise. sim/mn10300/: * config.in: Regenerate. * configure: Likewise. sim/ppc/: * config.in: Regenerate. * configure: Likewise. sim/erc32/: * config.in: Regenerate. * configure: Likewise. sim/arm/: * config.in: Regenerate. * configure: Likewise. sim/m68hc11/: * config.in: Regenerate. * configure: Likewise. sim/lm32/: * config.in: Regenerate. * configure: Likewise. sim/sh64/: * config.in: Regenerate. * configure: Likewise. sim/v850/: * config.in: Regenerate. * configure: Likewise. sim/cr16/: * config.in: Regenerate. * configure: Likewise. sim/moxie/: * config.in: Regenerate. * configure: Likewise. sim/m32c/: * config.in: Regenerate. * configure: Likewise. sim/mips/: * config.in: Regenerate. * configure: Likewise. sim/mcore/: * config.in: Regenerate. * configure: Likewise. sim/testsuite/d10v-elf/: * configure: Regenerate. sim/testsuite/: * configure: Regenerate. sim/testsuite/frv-elf/: * configure: Regenerate. sim/testsuite/m32r-elf/: * configure: Regenerate. sim/testsuite/mips64el-elf/: * configure: Regenerate. sim/sh/: * config.in: Regenerate. * configure: Likewise. gold/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. * testsuite/Makefile.in: Likewise. gprof/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * configure: Likewise. * gconfig.in: Likewise. opcodes/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. gas/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. * doc/Makefile.in: Likewise. ld/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. gdb/: * aclocal.m4: Regenerate. * config.in: Likewise. * configure: Likewise. * gnulib/Makefile.in: Likewise. gdb/doc/: * configure: Regenerate. gdb/gdbserver/: * aclocal.m4: Regenerate. * config.in: Likewise. * configure: Likewise. gdb/testsuite/: * configure: Regenerate. * gdb.hp/configure: Likewise. * gdb.hp/gdb.aCC/configure: Likewise. * gdb.hp/gdb.base-hp/configure: Likewise. * gdb.hp/gdb.compat/configure: Likewise. * gdb.hp/gdb.defects/configure: Likewise. * gdb.hp/gdb.objdbg/configure: Likewise. * gdb.stabs/configure: Likewise. binutils/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. * doc/Makefile.in: Likewise. bfd/: * Makefile.in: Regenerate. * aclocal.m4: Likewise. * config.in: Likewise. * configure: Likewise. bfd/doc/: * Makefile.in: Regenerate. readline/: * configure: Regenerate. readline/examples/rlfe/: * configure: Regenerate.
2009-08-22 16:56:56 +00:00
2009-08-22 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
* configure: Regenerate.
2009-01-18 Hans-Peter Nilsson <hp@axis.com>
* lib/sim-defs.exp (run_sim_test): New option progopts.
Index: m32r/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: m68hc11/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: mcore/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: mips/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: mn10300/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: ppc/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure.ac: Delete AC_CONFIG_AUX_DIR. * configure: Re-generate. Index: sh/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: testsuite/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: v850/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: erc32/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: frv/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: h8300/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: igen/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure.ac: Delete AC_CONFIG_AUX_DIR. * configure: Re-generate. Index: d10v/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: ChangeLog 2005-01-11 Andrew Cagney <cagney@gnu.org> * Makefile.in (autoconf-common autoheader-common): Add --force to autoconf and autoheader. (autoconf-common autoheader-common) (autoconf-install autoheader-install): Check for configure.ac, not configure.in. * configure.ac: Delete AC_CONFIG_AUX_DIR. * configure: Re-generate. Index: arm/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * configure: Regenerated to track ../common/aclocal.m4 changes. Index: common/ChangeLog 2005-01-11 Andrew Cagney <cagney@localhost.localdomain> * aclocal.m4 (SIM_AC_OUTPUT): Rewrite to use 2.59 macros. * configure: Regenerated to track ../common/aclocal.m4 changes.
2005-01-12 16:23:24 +00:00
2005-01-11 Andrew Cagney <cagney@localhost.localdomain>
* configure: Regenerated to track ../common/aclocal.m4 changes.
2005-01-07 Andrew Cagney <cagney@gnu.org>
Index: arm/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Replace configure.in. Requires autoconf 2.59 and correctly calls AC_CONFIG_SUBDIRS. * configure: Re-generate. Index: common/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * aclocal.m4 (SIM_AC_COMMON): Delete call to AC_CONFIG_AUX_DIR. * configure: Re-generate. Index: d10v/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: erc32/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: frv/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: h8300/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: igen/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: m32r/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: m68hc11/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: mcore/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: mips/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: mn10300/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: ppc/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: sh/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: testsuite/d10v-elf/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: testsuite/frv-elf/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: testsuite/m32r-elf/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: testsuite/mips64el-elf/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: testsuite/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate. Index: v850/ChangeLog 2005-01-07 Andrew Cagney <cagney@gnu.org> * configure.ac: Rename configure.in, require autoconf 2.59. * configure: Re-generate.
2005-01-10 16:14:50 +00:00
* configure.ac: Rename configure.in, require autoconf 2.59.
* configure: Re-generate.
* configure.in: Pass literal subdirectories to AC_CONFIG_SUBDIRS.
* configure: Re-generate.
* fr30-elf, d30v-elf: Delete directory.
2004-11-16 Hans-Peter Nilsson <hp@axis.com>
* lib/sim-defs.exp (run_sim_test): Make multiple "output"
specifications concatenate, not override.
Support "xfail" and "kfail".
2004-10-26 Nick Clifton <nickc@redhat.com>
* lib/sim-defs.exp (sim_run): Add support for the "rawsid"
protocol.
2004-09-13 DJ Delorie <dj@redhat.com>
* lib/sim-defs.exp (run_sim_test): Add global_as_options,
global_ld_options, and global_sim_options to all test cases, if
defined.
2004-05-12 Ben Elliston <bje@au.ibm.com>
* lib/sim-defs.exp: Remove stray semicolons.
2004-01-26 Chris Demetriou <cgd@broadcom.com>
* sim/mips: New directory. Tests for the MIPS simulator.
2004-01-23 Ben Elliston <bje@wasabisystems.com>
* lib/sim-defs.exp (run_sim_test): Delete the .o and .x files if a
test passes.
2003-08-20 Michael Snyder <msnyder@redhat.com>
On behalf of Dave Brolley
* sim/frv: New testsuite.
* frv-elf: New testsuite.
2003-07-09 Michael Snyder <msnyder@redhat.com>
* sim/sh: New directory. Tests for Renesas sh family.
2003-04-13 Michael Snyder <msnyder@redhat.com>
* sim/h8300: New directory. Tests for Renesas h8/300 family.
2002-06-16 Andrew Cagney <ac131313@redhat.com>
* configure: Regenerated to track ../common/aclocal.m4 changes.
2001-07-31 Ben Elliston <bje@redhat.com>
* lib/sim-defs.exp (run_sim_test): Include a description such as
"assembling" or "linking" that identifies the phase a test fails
in, for easier analysis of failures.
2000-11-01 Dave Brolley <brolley@cygnus.com>
* lib/sim-defs.exp (run_sm_test): Correct comment. "output" and
"xerror" options do not use a list of machines. Clear options from
previous test case. Use "$cpu_option" to identify the machine to the
assembler, if specified.
Tue May 23 21:39:23 2000 Andrew Cagney <cagney@b1.cygnus.com>
* configure: Regenerated to track ../common/aclocal.m4 changes.
1999-09-22 03:28:34 +00:00
1999-09-15 Doug Evans <devans@casey.cygnus.com>
* sim/arm/b.cgs: New testcase.
* sim/arm/bic.cgs: New testcase.
* sim/arm/bl.cgs: New testcase.
1999-09-09 00:02:17 +00:00
Thu Sep 2 18:15:53 1999 Andrew Cagney <cagney@b1.cygnus.com>
* configure: Regenerated to track ../common/aclocal.m4 changes.
1999-08-31 01:14:27 +00:00
1999-08-30 Doug Evans <devans@casey.cygnus.com>
* lib/sim-defs.exp (run_sim_test): Rename all_machs arg to
requested_machs, now is list of machs to run tests for.
Delete locals AS,ASFLAGS,LD,LDFLAGS. Use target_assemble
and target_link instead.
Fri Feb 5 12:41:11 1999 Doug Evans <devans@canuck.cygnus.com>
* lib/sim-defs.exp (sim_run): Print simulator arguments log message.
1999-01-05 Doug Evans <devans@casey.cygnus.com>
* lib/sim-defs.exp (run_sim_test): New arg all_machs.
1998-12-14 Doug Evans <devans@casey.cygnus.com>
* lib/sim-defs.exp (run_sim_test): New option xerror, for expected
errors. Translate \n sequences in expected output to newline char.
(slurp_options): Make parentheses optional.
(sim_run): Look for board_info sim,options.
Wed Nov 18 10:50:19 1998 Andrew Cagney <cagney@b1.cygnus.com>
* common/bits-gen.c (main): Add BYTE_ORDER so that it matches
recent sim/common/sim-basics.h changes.
* common/Makefile.in: Update.
Fri Oct 30 00:37:31 1998 Felix Lee <flee@cygnus.com>
* lib/sim-defs.exp (sim_run): download target program to remote
host, if necessary. for unix-driven win32 testing.
1999-04-26 18:34:20 +00:00
Fri Jul 31 17:49:13 1998 Felix Lee <flee@cygnus.com>
* lib/sim-defs.exp (sim_run): remote_spawn, use writeto instead of
writeonly.
Fri Jul 24 09:40:34 1998 Doug Evans <devans@canuck.cygnus.com>
* Makefile.in (clean,mostlyclean): Change leading spaces to a tab.
1999-04-26 18:34:20 +00:00
Tue Jun 16 15:44:01 1998 Jillian Ye <jillian@cygnus.com>
* lib/sim-defs.exp: Print out timeout setting info when "-v" is used.
Thu Jun 11 15:24:53 1998 Doug Evans <devans@canuck.cygnus.com>
* lib/sim-defs.exp (sim_run): Argument env_vals renamed to options,
which is now a list of options controlling the behaviour of sim_run.
Mon Jun 1 18:54:22 1998 Frank Ch. Eigler <fche@cygnus.com>
* lib/sim-defs.exp (sim_run): Add possible environment variable
list to simulator run.
Thu May 28 14:59:46 1998 Jillian Ye <jillian@cygnus.com>
* Makefile.in: Take RUNTEST out of FLAG_TO_PASS
so that make check can be invoked recursively.
Thu May 14 11:48:35 1998 Doug Evans <devans@canuck.cygnus.com>
* config/default.exp (CC,SIM): Delete.
* lib/sim-defs.exp (sim_run): Fix handling of output redirection.
New arg prog_opts. All callers updated.
Fri May 8 18:10:28 1998 Jillian Ye <jillian@cygnus.com>
* Makefile.in: Made "check" the target of two
dependencies (test1, test2) so that test2 get a chance to
run even when test1 failed if "make -k check" is used.
Fri May 8 14:41:28 1998 Doug Evans <devans@canuck.cygnus.com>
* lib/sim-defs.exp (sim_version): Simplify.
(sim_run): Implement.
(run_sim_test): Use sim_run.
(sim_compile): New proc.
Mon May 4 17:59:11 1998 Frank Ch. Eigler <fche@cygnus.com>
* config/default.exp: Added C compiler settings.
Wed Apr 22 12:26:28 1998 Doug Evans <devans@canuck.cygnus.com>
* Makefile.in (TARGET_FLAGS_TO_PASS): Delete LIBS, LDFLAGS.
Tue Apr 21 10:49:03 1998 Doug Evans <devans@canuck.cygnus.com>
* lib/sim-defs.exp (run_sim_test): Don't exit early if one mach fails,
try all machs.
Wed Feb 25 11:01:17 1998 Doug Evans <devans@canuck.cygnus.com>
* Makefile.in (RUNTEST): Fix path to runtest.
Tue Feb 17 12:46:05 1998 Doug Evans <devans@seba.cygnus.com>
* config/default.exp: New file.
* lib/sim-defs.exp: New file.
* Makefile.in (build_alias): Define.
(arch): Define.
(RUNTEST_FOR_TARGET): Delete.
(RUNTEST): Fix.
(check): Depend on site.exp. Run dejagnu.
(site.exp): New target.
* configure.in (arch): Define from target_cpu.
* configure: Regenerate.
Wed Sep 17 10:21:26 1997 Andrew Cagney <cagney@b1.cygnus.com>
* common/bits-gen.c (gen_bit): Pass in the full name of the macro.
(gen_mask): Ditto.
* common/bits-tst.c (main): Add tests for LSSEXT, MSSEXT.
(calc): Add support for 8 bit version of macros.
(main): Add tests for 8 bit versions of macros.
(check_sext): Check SEXT of zero clears bits.
* common/bits-gen.c (main): Generate tests for 8 bit versions of
macros.
Thu Sep 11 13:04:40 1997 Andrew Cagney <cagney@b1.cygnus.com>
* common/Make-common.in: New file, provide generic rules for
running checks.
Mon Sep 1 16:43:55 1997 Andrew Cagney <cagney@b1.cygnus.com>
* configure.in (configdirs): Test for the target directory instead
of matching on a target.