2016-01-01 04:33:14 +00:00
|
|
|
/* Copyright (C) 1992-2016 Free Software Foundation, Inc.
|
2013-10-31 08:50:15 +00:00
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include "defs.h"
|
|
|
|
#include "target-dcache.h"
|
|
|
|
#include "gdbcmd.h"
|
2013-10-31 14:18:10 +00:00
|
|
|
#include "progspace.h"
|
2013-10-31 08:50:15 +00:00
|
|
|
|
2013-10-31 14:18:10 +00:00
|
|
|
/* The target dcache is kept per-address-space. This key lets us
|
|
|
|
associate the cache with the address space. */
|
|
|
|
|
|
|
|
static const struct address_space_data *target_dcache_aspace_key;
|
|
|
|
|
|
|
|
/* Clean up dcache, represented by ARG, which is associated with
|
|
|
|
ASPACE. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
target_dcache_cleanup (struct address_space *aspace, void *arg)
|
|
|
|
{
|
2015-09-25 18:08:07 +00:00
|
|
|
dcache_free ((DCACHE *) arg);
|
2013-10-31 14:18:10 +00:00
|
|
|
}
|
2013-10-31 08:50:15 +00:00
|
|
|
|
|
|
|
/* Target dcache is initialized or not. */
|
|
|
|
|
|
|
|
int
|
|
|
|
target_dcache_init_p (void)
|
|
|
|
{
|
2015-09-25 18:08:07 +00:00
|
|
|
DCACHE *dcache
|
|
|
|
= (DCACHE *) address_space_data (current_program_space->aspace,
|
|
|
|
target_dcache_aspace_key);
|
2013-10-31 14:18:10 +00:00
|
|
|
|
|
|
|
return (dcache != NULL);
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Invalidate the target dcache. */
|
|
|
|
|
|
|
|
void
|
|
|
|
target_dcache_invalidate (void)
|
|
|
|
{
|
2015-09-25 18:08:07 +00:00
|
|
|
DCACHE *dcache
|
|
|
|
= (DCACHE *) address_space_data (current_program_space->aspace,
|
|
|
|
target_dcache_aspace_key);
|
2013-10-31 14:18:10 +00:00
|
|
|
|
|
|
|
if (dcache != NULL)
|
|
|
|
dcache_invalidate (dcache);
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Return the target dcache. Return NULL if target dcache is not
|
|
|
|
initialized yet. */
|
|
|
|
|
|
|
|
DCACHE *
|
|
|
|
target_dcache_get (void)
|
|
|
|
{
|
2015-09-25 18:08:07 +00:00
|
|
|
DCACHE *dcache
|
|
|
|
= (DCACHE *) address_space_data (current_program_space->aspace,
|
|
|
|
target_dcache_aspace_key);
|
2013-10-31 14:18:10 +00:00
|
|
|
|
|
|
|
return dcache;
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Return the target dcache. If it is not initialized yet, initialize
|
|
|
|
it. */
|
|
|
|
|
|
|
|
DCACHE *
|
|
|
|
target_dcache_get_or_init (void)
|
|
|
|
{
|
2015-09-25 18:08:07 +00:00
|
|
|
DCACHE *dcache
|
|
|
|
= (DCACHE *) address_space_data (current_program_space->aspace,
|
|
|
|
target_dcache_aspace_key);
|
2013-10-31 08:50:15 +00:00
|
|
|
|
2013-10-31 14:18:10 +00:00
|
|
|
if (dcache == NULL)
|
2013-11-20 12:59:47 +00:00
|
|
|
{
|
|
|
|
dcache = dcache_init ();
|
|
|
|
set_address_space_data (current_program_space->aspace,
|
|
|
|
target_dcache_aspace_key, dcache);
|
|
|
|
}
|
2013-10-31 14:18:10 +00:00
|
|
|
|
|
|
|
return dcache;
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* The option sets this. */
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
static int stack_cache_enabled_1 = 1;
|
|
|
|
/* And set_stack_cache updates this.
|
2013-10-31 08:50:15 +00:00
|
|
|
The reason for the separation is so that we don't flush the cache for
|
|
|
|
on->on transitions. */
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
static int stack_cache_enabled = 1;
|
2013-10-31 08:50:15 +00:00
|
|
|
|
|
|
|
/* This is called *after* the stack-cache has been set.
|
|
|
|
Flush the cache for off->on and on->off transitions.
|
|
|
|
There's no real need to flush the cache for on->off transitions,
|
|
|
|
except cleanliness. */
|
|
|
|
|
|
|
|
static void
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
set_stack_cache (char *args, int from_tty, struct cmd_list_element *c)
|
2013-10-31 08:50:15 +00:00
|
|
|
{
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
if (stack_cache_enabled != stack_cache_enabled_1)
|
2013-10-31 08:50:15 +00:00
|
|
|
target_dcache_invalidate ();
|
|
|
|
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
stack_cache_enabled = stack_cache_enabled_1;
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
show_stack_cache (struct ui_file *file, int from_tty,
|
|
|
|
struct cmd_list_element *c, const char *value)
|
2013-10-31 08:50:15 +00:00
|
|
|
{
|
|
|
|
fprintf_filtered (file, _("Cache use for stack accesses is %s.\n"), value);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Return true if "stack cache" is enabled, otherwise, return false. */
|
|
|
|
|
|
|
|
int
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
stack_cache_enabled_p (void)
|
2013-10-31 08:50:15 +00:00
|
|
|
{
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
return stack_cache_enabled;
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|
|
|
|
|
2013-11-01 04:26:10 +00:00
|
|
|
/* The option sets this. */
|
|
|
|
|
|
|
|
static int code_cache_enabled_1 = 1;
|
|
|
|
|
|
|
|
/* And set_code_cache updates this.
|
|
|
|
The reason for the separation is so that we don't flush the cache for
|
|
|
|
on->on transitions. */
|
|
|
|
static int code_cache_enabled = 1;
|
|
|
|
|
|
|
|
/* This is called *after* the code-cache has been set.
|
|
|
|
Flush the cache for off->on and on->off transitions.
|
|
|
|
There's no real need to flush the cache for on->off transitions,
|
|
|
|
except cleanliness. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
set_code_cache (char *args, int from_tty, struct cmd_list_element *c)
|
|
|
|
{
|
|
|
|
if (code_cache_enabled != code_cache_enabled_1)
|
|
|
|
target_dcache_invalidate ();
|
|
|
|
|
|
|
|
code_cache_enabled = code_cache_enabled_1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Show option "code-cache". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
show_code_cache (struct ui_file *file, int from_tty,
|
|
|
|
struct cmd_list_element *c, const char *value)
|
|
|
|
{
|
|
|
|
fprintf_filtered (file, _("Cache use for code accesses is %s.\n"), value);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Return true if "code cache" is enabled, otherwise, return false. */
|
|
|
|
|
|
|
|
int
|
|
|
|
code_cache_enabled_p (void)
|
|
|
|
{
|
|
|
|
return code_cache_enabled;
|
|
|
|
}
|
|
|
|
|
2013-10-31 08:50:15 +00:00
|
|
|
/* -Wmissing-prototypes */
|
|
|
|
extern initialize_file_ftype _initialize_target_dcache;
|
|
|
|
|
|
|
|
void
|
|
|
|
_initialize_target_dcache (void)
|
|
|
|
{
|
|
|
|
add_setshow_boolean_cmd ("stack-cache", class_support,
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
&stack_cache_enabled_1, _("\
|
2013-10-31 08:50:15 +00:00
|
|
|
Set cache use for stack access."), _("\
|
|
|
|
Show cache use for stack access."), _("\
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
When on, use the target memory cache for all stack access, regardless of any\n\
|
2013-10-31 08:50:15 +00:00
|
|
|
configured memory regions. This improves remote performance significantly.\n\
|
|
|
|
By default, caching for stack access is on."),
|
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
2013-11-20 08:21:47 +00:00
|
|
|
set_stack_cache,
|
|
|
|
show_stack_cache,
|
2013-10-31 08:50:15 +00:00
|
|
|
&setlist, &showlist);
|
2013-10-31 14:18:10 +00:00
|
|
|
|
2013-11-01 04:26:10 +00:00
|
|
|
add_setshow_boolean_cmd ("code-cache", class_support,
|
|
|
|
&code_cache_enabled_1, _("\
|
|
|
|
Set cache use for code segment access."), _("\
|
|
|
|
Show cache use for code segment access."), _("\
|
|
|
|
When on, use the target memory cache for all code segment accesses,\n\
|
|
|
|
regardless of any configured memory regions. This improves remote\n\
|
|
|
|
performance significantly. By default, caching for code segment\n\
|
|
|
|
access is on."),
|
|
|
|
set_code_cache,
|
|
|
|
show_code_cache,
|
|
|
|
&setlist, &showlist);
|
|
|
|
|
2013-10-31 14:18:10 +00:00
|
|
|
target_dcache_aspace_key
|
|
|
|
= register_address_space_data_with_cleanup (NULL,
|
|
|
|
target_dcache_cleanup);
|
2013-10-31 08:50:15 +00:00
|
|
|
}
|