old-cross-binutils/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp

49 lines
1.5 KiB
Text
Raw Normal View History

# Copyright 2004-2005, 2007-2012 Free Software Foundation, Inc.
[dwarf] Anonymous nested function causes SEGV during psymbol read According to the DWARF3 standard, a function always has a name attribute (Section 3.3 - Subroutine and Entry Point Entries). The only exception is when a DW_AT_abstract_origin attribute is provided, in which case the name may be inherited from the referenced DIE. The problem occured because our compiler generated a subprogram DIE for a nested function where the name attribute was missing (and no abstract-origin either). Our code in add_partial_symbol is not prepared to deal with the situation, and happily just tries to compute the length of the (NULL) function name. This normally cannot happen, because there is already a guard in scan_partial_symbols, where we (silently!) ignore anonymous dies, including anonymous subprograms. Unfortunately, there is a flaw that affects Ada and other languages that allow nested subprograms. For nested subprograms, we do not go through scan_partial_symbols and thus we are missing the name check. This patch adds the name check in the nested subprogram case. It also adds a complaint which is emitted during the psymtab->symtab conversion phase. gdb/ChangeLog: * dwarf2read.c (add_partial_subprogram): Make sure the subprogram DIE has a name before creating the associated partial symbol. (read_func_scope): Emit a complaint if the subprogram does not have a name or when we can't extract the subprogram PC bounds. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-anonymous-func.S: New file. * gdb.dwarf2/dw2-anonymous-func.exp: New testcase. Tested on x86_64-linux, no regression. Note that the testcase also verifies that the psymtab->symtab conversion does not crash (this is the purpose of the "list file1.txt:1" test.
2010-03-18 18:35:55 +00:00
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
2011-01-19 Yao Qi <yao@codesourcery.com> * gdb.asm/asm-source.exp: Replace ARM target triplet with a canonical form. Remove "xscale-*-*" * gdb.xml/tdesc-regs.exp: Likewise. * gdb.python/py-section-script.exp: Replace ARM target triplet with canonical form. Match arm*-*-symbianelf*. * gdb.base/dup-sect.exp: Likewise. * lib/dwarf.exp: New. * gdb.dwarf2/callframecfa.exp: Check dwarf2 support by routine dwarf2_support. * gdb.dwarf2/dup-psym.exp: Likewise. * gdb.dwarf2/dw2-ada-ffffffff.exp: Likewise. * gdb.dwarf2/dw2-anonymous-func.exp: Likewise. * gdb.dwarf2/dw2-bad-parameter-type.exp: Likewise. * gdb.dwarf2/dw2-basic.exp: Likewise. * gdb.dwarf2/dw2-compressed.exp: Likewise. * gdb.dwarf2/dw2-const.exp: Likewise. * gdb.dwarf2/dw2-cp-infcall-ref-static.exp: Likewise. * gdb.dwarf2/dw2-cu-size.exp: Likewise. * gdb.dwarf2/dw2-double-set-die-type.exp: Likewise. * gdb.dwarf2/dw2-empty-namespace.exp: Likewise. * gdb.dwarf2/dw2-filename.exp: Likewise. * gdb.dwarf2/dw2-inheritance.exp: Likewise. * gdb.dwarf2/dw2-inline-param.exp: Likewise. * gdb.dwarf2/dw2-intercu.exp: Likewise. * gdb.dwarf2/dw2-intermix.exp: Likewise. * gdb.dwarf2/dw2-modula2-self-type.exp: Likewise. * gdb.dwarf2/dw2-noloc.exp: Likewise. * gdb.dwarf2/dw2-op-call.exp: Likewise. * gdb.dwarf2/dw2-producer.exp: Likewise. * gdb.dwarf2/dw2-ranges.exp: Likewise. * gdb.dwarf2/dw2-ref-missing-frame.exp: Likewise. * gdb.dwarf2/dw2-stack-boundary.exp: Likewise. * gdb.dwarf2/dw2-strp.exp: Likewise. * gdb.dwarf2/dw2-unresolved.exp: Likewise. * gdb.dwarf2/implptr.exp: Likewise. * gdb.dwarf2/mac-fileno.exp: Likewise. * gdb.dwarf2/member-ptr-forwardref.exp: Likewise. * gdb.dwarf2/pieces.exp: Likewise. * gdb.dwarf2/pr11465.exp: Likewise. * gdb.dwarf2/valop.exp: Likewise. * gdb.dwarf2/watch-notconst.exp: Likewise. * gdb.mi/dw2-ref-missing-frame.exp: Likewise.
2011-01-19 20:26:10 +00:00
load_lib dwarf.exp
[dwarf] Anonymous nested function causes SEGV during psymbol read According to the DWARF3 standard, a function always has a name attribute (Section 3.3 - Subroutine and Entry Point Entries). The only exception is when a DW_AT_abstract_origin attribute is provided, in which case the name may be inherited from the referenced DIE. The problem occured because our compiler generated a subprogram DIE for a nested function where the name attribute was missing (and no abstract-origin either). Our code in add_partial_symbol is not prepared to deal with the situation, and happily just tries to compute the length of the (NULL) function name. This normally cannot happen, because there is already a guard in scan_partial_symbols, where we (silently!) ignore anonymous dies, including anonymous subprograms. Unfortunately, there is a flaw that affects Ada and other languages that allow nested subprograms. For nested subprograms, we do not go through scan_partial_symbols and thus we are missing the name check. This patch adds the name check in the nested subprogram case. It also adds a complaint which is emitted during the psymtab->symtab conversion phase. gdb/ChangeLog: * dwarf2read.c (add_partial_subprogram): Make sure the subprogram DIE has a name before creating the associated partial symbol. (read_func_scope): Emit a complaint if the subprogram does not have a name or when we can't extract the subprogram PC bounds. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-anonymous-func.S: New file. * gdb.dwarf2/dw2-anonymous-func.exp: New testcase. Tested on x86_64-linux, no regression. Note that the testcase also verifies that the psymtab->symtab conversion does not crash (this is the purpose of the "list file1.txt:1" test.
2010-03-18 18:35:55 +00:00
# Minimal DWARF-2 unit test
# This test can only be run on targets which support DWARF-2 and use gas.
2011-01-19 Yao Qi <yao@codesourcery.com> * gdb.asm/asm-source.exp: Replace ARM target triplet with a canonical form. Remove "xscale-*-*" * gdb.xml/tdesc-regs.exp: Likewise. * gdb.python/py-section-script.exp: Replace ARM target triplet with canonical form. Match arm*-*-symbianelf*. * gdb.base/dup-sect.exp: Likewise. * lib/dwarf.exp: New. * gdb.dwarf2/callframecfa.exp: Check dwarf2 support by routine dwarf2_support. * gdb.dwarf2/dup-psym.exp: Likewise. * gdb.dwarf2/dw2-ada-ffffffff.exp: Likewise. * gdb.dwarf2/dw2-anonymous-func.exp: Likewise. * gdb.dwarf2/dw2-bad-parameter-type.exp: Likewise. * gdb.dwarf2/dw2-basic.exp: Likewise. * gdb.dwarf2/dw2-compressed.exp: Likewise. * gdb.dwarf2/dw2-const.exp: Likewise. * gdb.dwarf2/dw2-cp-infcall-ref-static.exp: Likewise. * gdb.dwarf2/dw2-cu-size.exp: Likewise. * gdb.dwarf2/dw2-double-set-die-type.exp: Likewise. * gdb.dwarf2/dw2-empty-namespace.exp: Likewise. * gdb.dwarf2/dw2-filename.exp: Likewise. * gdb.dwarf2/dw2-inheritance.exp: Likewise. * gdb.dwarf2/dw2-inline-param.exp: Likewise. * gdb.dwarf2/dw2-intercu.exp: Likewise. * gdb.dwarf2/dw2-intermix.exp: Likewise. * gdb.dwarf2/dw2-modula2-self-type.exp: Likewise. * gdb.dwarf2/dw2-noloc.exp: Likewise. * gdb.dwarf2/dw2-op-call.exp: Likewise. * gdb.dwarf2/dw2-producer.exp: Likewise. * gdb.dwarf2/dw2-ranges.exp: Likewise. * gdb.dwarf2/dw2-ref-missing-frame.exp: Likewise. * gdb.dwarf2/dw2-stack-boundary.exp: Likewise. * gdb.dwarf2/dw2-strp.exp: Likewise. * gdb.dwarf2/dw2-unresolved.exp: Likewise. * gdb.dwarf2/implptr.exp: Likewise. * gdb.dwarf2/mac-fileno.exp: Likewise. * gdb.dwarf2/member-ptr-forwardref.exp: Likewise. * gdb.dwarf2/pieces.exp: Likewise. * gdb.dwarf2/pr11465.exp: Likewise. * gdb.dwarf2/valop.exp: Likewise. * gdb.dwarf2/watch-notconst.exp: Likewise. * gdb.mi/dw2-ref-missing-frame.exp: Likewise.
2011-01-19 20:26:10 +00:00
if {![dwarf2_support]} {
[dwarf] Anonymous nested function causes SEGV during psymbol read According to the DWARF3 standard, a function always has a name attribute (Section 3.3 - Subroutine and Entry Point Entries). The only exception is when a DW_AT_abstract_origin attribute is provided, in which case the name may be inherited from the referenced DIE. The problem occured because our compiler generated a subprogram DIE for a nested function where the name attribute was missing (and no abstract-origin either). Our code in add_partial_symbol is not prepared to deal with the situation, and happily just tries to compute the length of the (NULL) function name. This normally cannot happen, because there is already a guard in scan_partial_symbols, where we (silently!) ignore anonymous dies, including anonymous subprograms. Unfortunately, there is a flaw that affects Ada and other languages that allow nested subprograms. For nested subprograms, we do not go through scan_partial_symbols and thus we are missing the name check. This patch adds the name check in the nested subprogram case. It also adds a complaint which is emitted during the psymtab->symtab conversion phase. gdb/ChangeLog: * dwarf2read.c (add_partial_subprogram): Make sure the subprogram DIE has a name before creating the associated partial symbol. (read_func_scope): Emit a complaint if the subprogram does not have a name or when we can't extract the subprogram PC bounds. gdb/testsuite/ChangeLog: * gdb.dwarf2/dw2-anonymous-func.S: New file. * gdb.dwarf2/dw2-anonymous-func.exp: New testcase. Tested on x86_64-linux, no regression. Note that the testcase also verifies that the psymtab->symtab conversion does not crash (this is the purpose of the "list file1.txt:1" test.
2010-03-18 18:35:55 +00:00
return 0
}
set testfile "dw2-anonymous-func"
set dwarf_srcfile "file1.txt"
set srcfile ${testfile}.S
set binfile ${objdir}/${subdir}/${testfile}.x
if { [gdb_compile "${srcdir}/${subdir}/main.c" "main.o" object {debug}] != "" } {
return -1
}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${testfile}.o" object {nodebug}] != "" } {
return -1
}
if { [gdb_compile "${testfile}.o main.o" "${binfile}" executable {debug}] != "" } {
return -1
}
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
# Force the debugger to create the file1.txt symtab, to make sure that
# the debugger does not crash doing so.
gdb_test "list file1.txt:1" "File 1 Line 1.*File 1 Line 8" "list file1.txt"