352eff9062
* add check on template extension type - throw error if invalid
154 lines
4.1 KiB
Go
154 lines
4.1 KiB
Go
// Copyright 2019 Drone.IO Inc. All rights reserved.
|
|
// Use of this source code is governed by the Drone Non-Commercial License
|
|
// that can be found in the LICENSE file.
|
|
|
|
// +build !oss
|
|
|
|
package template
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
|
|
"github.com/drone/drone/core"
|
|
"github.com/drone/drone/handler/api/errors"
|
|
"github.com/drone/drone/mock"
|
|
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/go-chi/chi"
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/google/go-cmp/cmp"
|
|
)
|
|
|
|
func TestHandleCreate(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
defer controller.Finish()
|
|
|
|
templates := mock.NewMockTemplateStore(controller)
|
|
templates.EXPECT().Create(gomock.Any(), gomock.Any()).Return(nil)
|
|
|
|
c := new(chi.Context)
|
|
|
|
in := new(bytes.Buffer)
|
|
json.NewEncoder(in).Encode(dummyTemplate)
|
|
|
|
w := httptest.NewRecorder()
|
|
r := httptest.NewRequest("GET", "/", in)
|
|
r = r.WithContext(
|
|
context.WithValue(context.Background(), chi.RouteCtxKey, c),
|
|
)
|
|
|
|
HandleCreate(templates).ServeHTTP(w, r)
|
|
if got, want := w.Code, http.StatusOK; want != got {
|
|
t.Errorf("Want response code %d, got %d", want, got)
|
|
}
|
|
}
|
|
|
|
func TestHandleCreate_NotValidTemplateExtensionName(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
defer controller.Finish()
|
|
|
|
c := new(chi.Context)
|
|
in := new(bytes.Buffer)
|
|
json.NewEncoder(in).Encode(&core.Template{Name: "my_template", Data: "my_data"})
|
|
|
|
w := httptest.NewRecorder()
|
|
r := httptest.NewRequest("GET", "/", in)
|
|
r = r.WithContext(
|
|
context.WithValue(context.Background(), chi.RouteCtxKey, c),
|
|
)
|
|
|
|
HandleCreate(nil).ServeHTTP(w, r)
|
|
if got, want := w.Code, http.StatusBadRequest; want != got {
|
|
t.Errorf("Want response code %d, got %d", want, got)
|
|
}
|
|
|
|
got, want := &errors.Error{}, &errors.Error{Message: "Template extension invalid. Must be yaml, starlark or jsonnet"}
|
|
json.NewDecoder(w.Body).Decode(got)
|
|
if diff := cmp.Diff(got, want); len(diff) != 0 {
|
|
t.Errorf(diff)
|
|
}
|
|
}
|
|
|
|
func TestHandleCreate_ValidationErrorData(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
defer controller.Finish()
|
|
|
|
c := new(chi.Context)
|
|
in := new(bytes.Buffer)
|
|
json.NewEncoder(in).Encode(&core.Template{Name: "my_template.yml", Data: ""})
|
|
|
|
w := httptest.NewRecorder()
|
|
r := httptest.NewRequest("GET", "/", in)
|
|
r = r.WithContext(
|
|
context.WithValue(context.Background(), chi.RouteCtxKey, c),
|
|
)
|
|
|
|
HandleCreate(nil).ServeHTTP(w, r)
|
|
if got, want := w.Code, http.StatusBadRequest; want != got {
|
|
t.Errorf("Want response code %d, got %d", want, got)
|
|
}
|
|
|
|
got, want := &errors.Error{}, &errors.Error{Message: "No Template Data Provided"}
|
|
json.NewDecoder(w.Body).Decode(got)
|
|
if diff := cmp.Diff(got, want); len(diff) != 0 {
|
|
t.Errorf(diff)
|
|
}
|
|
}
|
|
|
|
func TestHandleCreate_BadRequest(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
defer controller.Finish()
|
|
|
|
c := new(chi.Context)
|
|
|
|
w := httptest.NewRecorder()
|
|
r := httptest.NewRequest("GET", "/", nil)
|
|
r = r.WithContext(
|
|
context.WithValue(context.Background(), chi.RouteCtxKey, c),
|
|
)
|
|
|
|
HandleCreate(nil).ServeHTTP(w, r)
|
|
if got, want := w.Code, http.StatusBadRequest; want != got {
|
|
t.Errorf("Want response code %d, got %d", want, got)
|
|
}
|
|
|
|
got, want := &errors.Error{}, &errors.Error{Message: "EOF"}
|
|
json.NewDecoder(w.Body).Decode(got)
|
|
if diff := cmp.Diff(got, want); len(diff) != 0 {
|
|
t.Errorf(diff)
|
|
}
|
|
}
|
|
|
|
func TestHandleCreate_CreateError(t *testing.T) {
|
|
controller := gomock.NewController(t)
|
|
defer controller.Finish()
|
|
|
|
templates := mock.NewMockTemplateStore(controller)
|
|
templates.EXPECT().Create(gomock.Any(), gomock.Any()).Return(errors.ErrNotFound)
|
|
|
|
c := new(chi.Context)
|
|
in := new(bytes.Buffer)
|
|
json.NewEncoder(in).Encode(dummyTemplate)
|
|
|
|
w := httptest.NewRecorder()
|
|
r := httptest.NewRequest("GET", "/", in)
|
|
r = r.WithContext(
|
|
context.WithValue(context.Background(), chi.RouteCtxKey, c),
|
|
)
|
|
|
|
HandleCreate(templates).ServeHTTP(w, r)
|
|
if got, want := w.Code, http.StatusInternalServerError; want != got {
|
|
t.Errorf("Want response code %d, got %d", want, got)
|
|
}
|
|
|
|
got, want := new(errors.Error), errors.ErrNotFound
|
|
json.NewDecoder(w.Body).Decode(got)
|
|
if diff := cmp.Diff(got, want); len(diff) != 0 {
|
|
t.Errorf(diff)
|
|
}
|
|
}
|