darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

batch: drop unpossible error check

Browse source 
in favor of annotated error message.
There is also unrelated diff due to gofmt.
This commit is contained in:
ferhat elmas 2019-04-13 17:40:06 +02:00
parent 4004cb6008
commit f4f6d13df9
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
store/batch/batch.go
View file

@ -77,10 +77,7 @@ func (b *batchUpdater) Batch(ctx context.Context, user *core.User, batch *core.B
} }
_, err = execer.Exec(stmt, args...) _, err = execer.Exec(stmt, args...)
if err != nil { if err != nil {
return err return fmt.Errorf("Error inserting repository: %s", err)
}
if err != nil {
return fmt.Errorf("Error inserting repositroy: %s", err)
} }
// //
@ -120,10 +117,7 @@ func (b *batchUpdater) Batch(ctx context.Context, user *core.User, batch *core.B
} }
_, err = execer.Exec(stmt, args...) _, err = execer.Exec(stmt, args...)
if err != nil { if err != nil {
return err return fmt.Errorf("Error updating repository: %s", err)
}
if err != nil {
return fmt.Errorf("Error updating repositroy: %s", err)
} }
stmt = permInsertIgnoreStmt stmt = permInsertIgnoreStmt
@ -235,7 +229,7 @@ const repoInsertIgnoreStmtPostgres = `
INSERT INTO repos ` + stmtInsertBase + ` ON CONFLICT DO NOTHING` INSERT INTO repos ` + stmtInsertBase + ` ON CONFLICT DO NOTHING`
const repoUpdateRemoteStmt = ` const repoUpdateRemoteStmt = `
UPDATE repos SET UPDATE repos SET
repo_namespace=:repo_namespace repo_namespace=:repo_namespace
,repo_name=:repo_name ,repo_name=:repo_name
,repo_slug=:repo_slug ,repo_slug=:repo_slug
@ -249,7 +243,7 @@ WHERE repo_id=:repo_id
` `
const repoUpdateRemoteStmtPostgres = ` const repoUpdateRemoteStmtPostgres = `
UPDATE repos SET UPDATE repos SET
repo_namespace=$1 repo_namespace=$1
,repo_name=$2 ,repo_name=$2
,repo_slug=$3 ,repo_slug=$3