darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fixed issue where not correctly adding perm for existing repo

Browse source
This commit is contained in:
Brad Rydzewski 2014-08-11 23:15:38 -07:00
parent ca2a93ed9f
commit dcdb1605b0
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
server/handler/login.go
View file

@ -129,12 +129,13 @@ func (h *LoginHandler) GetLogin(w http.ResponseWriter, r *http.Request) error {
repo.URL = remoteRepo.URL
if err := h.repos.Insert(repo); err != nil {
log.Println("Error adding repo.", u.Login, remoteRepo.Name, err)
// this is probably because the repository already exists.
// we should still attempt to grant the user access, however.
//
// todo(bradrydzewski) we should inspect the response to ensure
// the failure is caused by a primary key violation.
// typically we see a failure because the repository already exists
// in which case, we can retrieve the existing record to get the ID.
repo, err = h.repos.FindName(repo.Host, repo.Owner, repo.Name)
if err != nil {
log.Println("Error adding repo.", u.Login, remoteRepo.Name, err)
continue
}
}
// add user permissions