Run gofmt and add test to prevent regressions

Run `go fmt ./...` [1] and add a test to the `test` make target that
checks if `go fmt` has been run.

[1]: http://blog.golang.org/go-fmt-your-code
This commit is contained in:
Matt Bostock 2015-01-11 18:35:30 +00:00
parent 6ed8542f7d
commit b027bd8392
9 changed files with 84 additions and 83 deletions

View file

@ -9,6 +9,7 @@ deps:
go get -t -v ./...
test:
@test -z "$(shell find . -name '*.go' | xargs gofmt -l)" || (echo "Need to run 'go fmt ./...'"; exit 1)
go vet ./...
go test -cover -short ./...

View file

@ -30,7 +30,7 @@ func restartCommandFunc(c *cli.Context, client *client.Client) error {
case 2:
branch = "master"
sha = args[1]
case 3,4,5:
case 3, 4, 5:
branch = args[1]
sha = args[2]
}

View file

@ -35,7 +35,7 @@ func (h *Deis) Write(f *buildfile.Buildfile) {
// git@deis.yourdomain.com:2222/drone.git
f.WriteCmd(fmt.Sprintf("git remote add deis ssh://git@%s%s.git", h.Deisurl , h.App))
f.WriteCmd(fmt.Sprintf("git remote add deis ssh://git@%s%s.git", h.Deisurl, h.App))
switch h.Force {
case true:

View file

@ -5,9 +5,9 @@ import (
"github.com/drone/drone/shared/build/buildfile"
"github.com/drone/drone/shared/build/repo"
"github.com/drone/drone/plugin/deploy/deis"
"github.com/drone/drone/plugin/deploy/git"
"github.com/drone/drone/plugin/deploy/heroku"
"github.com/drone/drone/plugin/deploy/deis"
"github.com/drone/drone/plugin/deploy/modulus"
"github.com/drone/drone/plugin/deploy/nodejitsu"
"github.com/drone/drone/plugin/deploy/tsuru"