darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Do not request Read permission for public repo

Browse source 
Closes #882
This commit is contained in:
Vsevolod Strukchinsky 2015-02-20 12:05:39 +05:00
parent e9e4b64500
commit 83e03c1257
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
server/handler/ws.go
View file

@ -1,6 +1,7 @@
package handler
import (
"database/sql"
"log"
"net/http"
"strconv"
@ -65,14 +66,15 @@ func WsUser(c web.C, w http.ResponseWriter, r *http.Request) {
break
}
// user must have read access to the repository
role, permerr := datastore.GetPerm(ctx, user, work.Repo)
if permerr != nil && permerr != sql.ErrNoRows {
// for debugging
log.Printf("WS: Error getting permissions for repository %s. Error: %s\n", work.Repo.Name, permerr)
}
// user must have read access to private the repository
// in order to pass this message along
if role, err := datastore.GetPerm(ctx, user, work.Repo); err != nil || role.Read == false {
if err != nil {
log.Printf("WS: Error getting permissions for repository %s. Error: %s\n", work.Repo.Name, err)
} else {
log.Printf("WS: No read access for repository %s\n", work.Repo.Name)
}
if work.Repo.Private == true && role.Read == false {
break
}