darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

(feat) dont kill sibling pipelines if one fails

Browse source
This commit is contained in:
TP Honey 2021-12-08 11:41:58 +00:00
parent fff2f6608c
commit 8316e7474d
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
operator/manager/teardown.go
View file

@ -212,14 +212,25 @@ func (t *teardown) do(ctx context.Context, stage *core.Stage) error {
// cancelDownstream is a helper function that tests for // cancelDownstream is a helper function that tests for
// downstream stages and cancels them based on the overall // downstream stages and cancels them based on the overall
// pipeline state. // pipeline state.
func depFailed(listOne, listTwo []string) bool {
for _, i := range listOne {
for _, j := range listTwo {
if i == j {
return true
}
}
}
return false
}
func (t *teardown) cancelDownstream( func (t *teardown) cancelDownstream(
ctx context.Context, ctx context.Context,
stages []*core.Stage, stages []*core.Stage,
) error { ) error {
failed := false failedStages := []string{}
for _, s := range stages { for _, s := range stages {
if s.IsFailed() { if s.IsFailed() {
failed = true failedStages = append(failedStages, s.Name)
} }
} }
@ -230,10 +241,10 @@ func (t *teardown) cancelDownstream(
} }
var skip bool var skip bool
if failed == true && s.OnFailure == false { if depFailed(s.DependsOn, failedStages) == true && s.OnFailure == false {
skip = true skip = true
} }
if failed == false && s.OnSuccess == false { if depFailed(s.DependsOn, failedStages) == false && s.OnSuccess == false {
skip = true skip = true
} }
if skip == false { if skip == false {
@ -249,7 +260,7 @@ func (t *teardown) cancelDownstream(
"stage.id": s.ID, "stage.id": s.ID,
"stage.on_success": s.OnSuccess, "stage.on_success": s.OnSuccess,
"stage.on_failure": s.OnFailure, "stage.on_failure": s.OnFailure,
"stage.is_failure": failed, "stage.is_failure": failedStages,
"stage.depends_on": s.DependsOn, "stage.depends_on": s.DependsOn,
}, },
) )