darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

getting rid of string split and using the regex match

Browse source
This commit is contained in:
Jeff Storey 2016-03-30 07:58:24 -04:00
parent 3e4b871991
commit 79dc866f43
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
remote/github/github.go
View file

@ -260,14 +260,13 @@ func repoStatus(client *github.Client, r *model.Repo, b *model.Build, link strin
} }
func deploymentStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error { func deploymentStatus(client *github.Client, r *model.Repo, b *model.Build, link string) error {
// the deployment ID is only available in the the link to the build as the last element in the URL
parts := strings.Split(b.Link, "/")
matches := githubDeployRegex.FindStringSubmatch(b.Link) matches := githubDeployRegex.FindStringSubmatch(b.Link)
// if the deployment was not triggered from github, don't send a deployment status // if the deployment was not triggered from github, don't send a deployment status
if len(matches) != 2 { if len(matches) != 2 {
return nil return nil
} }
id, _ := strconv.Atoi(parts[len(parts)-1]) // the deployment ID is only available in the the link to the build as the last element in the URL
id, _ := strconv.Atoi(matches[1])
status := getStatus(b.Status) status := getStatus(b.Status)
desc := getDesc(b.Status) desc := getDesc(b.Status)
data := github.DeploymentStatusRequest{ data := github.DeploymentStatusRequest{