darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Urgent fix for changed auth behavior on Gitea

Browse source 
Within the PR https://github.com/go-gitea/gitea/pull/2184 on Gitea the
project dropped the standard behavior to use x-auth-basic personal
access token. So we should use a proper username and the token from now
on to support Gitea >= 1.2.0. Since this driver anyway only supports
Gitea >= 1.2.0 this won't be a breaking change on Drone side, the only
breaking change is on side of Gitea!
This commit is contained in:
Thomas Boerger 2017-10-12 14:33:25 +02:00
parent b727a3ce55
commit 517c003af2
No known key found for this signature in database
GPG key ID: 5A388F55283960B6
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
remote/gitea/gitea.go
View file

@ -271,8 +271,8 @@ func (c *client) Netrc(u *model.User, r *model.Repo) (*model.Netrc, error) {
}, nil
}
return &model.Netrc{
Login: u.Token,
Password: "x-oauth-basic",
Login: u.Login,
Password: u.Token,
Machine: c.Machine,
}, nil
}

4
remote/gitea/gitea_test.go
View file

@ -55,8 +55,8 @@ func Test_gitea(t *testing.T) {
})
netrc, _ := remote.Netrc(fakeUser, nil)
g.Assert(netrc.Machine).Equal("gitea.com")
g.Assert(netrc.Login).Equal(fakeUser.Token)
g.Assert(netrc.Password).Equal("x-oauth-basic")
g.Assert(netrc.Login).Equal(fakeUser.Login)
g.Assert(netrc.Password).Equal(fakeUser.Token)
})
g.It("Should return a netrc with the machine account", func() {
remote, _ := New(Opts{