From 302a8988484cfc654fd29e2dbc0105c8ec5a341e Mon Sep 17 00:00:00 2001 From: Brad Rydzewski Date: Sun, 3 Aug 2014 21:33:47 -0700 Subject: [PATCH] fixed missing dep in Makefile --- Makefile | 1 + plugin/notify/github/github.go | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/Makefile b/Makefile index 9369a002..e19043a9 100644 --- a/Makefile +++ b/Makefile @@ -5,6 +5,7 @@ all: build deps: # which npm && npm -g install uglify-js less go get github.com/GeertJohan/go.rice/rice + go get github.com/franela/goblin go list github.com/drone/drone/... | xargs go get -t -v test: diff --git a/plugin/notify/github/github.go b/plugin/notify/github/github.go index 2fcb81d5..844948ce 100644 --- a/plugin/notify/github/github.go +++ b/plugin/notify/github/github.go @@ -11,6 +11,10 @@ import ( "github.com/google/go-github/github" ) +// TODO (bradrydzewski) explore using the Repo.URL to parse the GitHub +// Entperprise Scheme+Hostname, instead of the environment variable. Is +// there any reason not to use the environment variable? + // GitHub enterprise URL var URL = os.Getenv("GITHUB_ENTERPRISE_API")