darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

if publish.docker.email is unspecified, pass in -e ' ' to avoid having the line end up as 'docker login -u foo -p bar -e someregistry', which is interpreted as 'log in user foo with pass bar and email someregistry to https://index.docker.io/v1/' (c.f. 'docker help login')

Browse source
This commit is contained in:
Henrik Jonsson 2015-04-01 18:21:33 +02:00
parent 0770e83662
commit 2526fb17c5
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugin/publish/docker.go
View file

@ -94,8 +94,14 @@ func (d *Docker) Write(f *buildfile.Buildfile) {
// Login?
if d.RegistryLogin == true {
// If email is unspecified, pass in -e ' ' to avoid having
// registry URL interpreted as email, which will fail cryptically.
emailOpt := "' '"
if d.Email != "" {
emailOpt = d.Email
}
f.WriteCmdSilent(fmt.Sprintf("docker login -u %s -p %s -e %s %s",
d.Username, d.Password, d.Email, d.RegistryLoginUrl))
d.Username, d.Password, emailOpt, d.RegistryLoginUrl))
}
// Tag and push all tags