darkkirb/harness-drone
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Defer updateGitHubStatus so that it reports errors that occur before the build begins

Browse source
This commit is contained in:
Scott Ferguson 2014-02-09 19:06:16 -06:00
parent cf9b791071
commit 1e75162bc8
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
pkg/queue/queue.go
View file

@ -12,6 +12,7 @@ import (
"github.com/drone/drone/pkg/mail" "github.com/drone/drone/pkg/mail"
. "github.com/drone/drone/pkg/model" . "github.com/drone/drone/pkg/model"
"github.com/drone/go-github/github" "github.com/drone/go-github/github"
"log"
"path/filepath" "path/filepath"
"time" "time"
) )
@ -134,6 +135,15 @@ func (b *BuildTask) execute() error {
builder.Key = []byte(b.Repo.PrivateKey) builder.Key = []byte(b.Repo.PrivateKey)
builder.Stdout = buf builder.Stdout = buf
builder.Timeout = 300 * time.Minute builder.Timeout = 300 * time.Minute
defer func() {
// update the status of the commit using the
// GitHub status API.
if err := updateGitHubStatus(b.Repo, b.Commit); err != nil {
log.Printf("error updating github status: %s\n", err.Error())
}
}()
buildErr := builder.Run() buildErr := builder.Run()
b.Build.Finished = time.Now().UTC() b.Build.Finished = time.Now().UTC()
@ -181,12 +191,6 @@ func (b *BuildTask) execute() error {
b.Script.Notifications.Send(context) b.Script.Notifications.Send(context)
} }
// update the status of the commit using the
// GitHub status API.
if err := updateGitHubStatus(b.Repo, b.Commit); err != nil {
return err
}
return nil return nil
} }